Skip to content

js errors on slideshow example #2

Closed

Description

@macgyver

Hey, I'm looking into using this as an alternative to the wonderful iScroll library and I was checking out the slideshow example on this page:

http://eightmedia.github.com/hammer.js/slideshow.html

I found that in Chrome and iOS, when trying to drag the slides a ton of javascript errors are raised:

slideshow.html:183, Uncaught TypeError: Cannot read property 'LEFT' of undefined
slideshow.html:202, Uncaught TypeError: Cannot read property 'RIGHT' of undefined

Activity

  1. jtangelder commented on Mar 23, 2012

    @jtangelder
    Member

    It is a bug in the demo, hammer.js had some changes in the api since the first demos were made. i need to fix these, probably next week.

  2. macgyver commented on Mar 23, 2012

    @macgyver
    Author

    Ah gotcha, just FYI your site was featured in the Javascript Weekly newsletter this morning (http://javascriptweekly.com/), a lot of people might be looking at that demo today.

  3. jtangelder commented on Mar 23, 2012

    @jtangelder
    Member

    Ah great! Thanks. I just fixed the slideshow and scroll demo :-)

  4. macgyver commented on Mar 23, 2012

    @macgyver
    Author

    Awesome!

  5. added a commit that references this issue on Jan 17, 2013
  6. added a commit that references this issue on Jul 12, 2016
  7. added a commit that references this issue on Oct 22, 2018
  8. added a commit that references this issue on Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions