fix(typecheck): unblock main — unused symbols from #450

[aarontrowbridge]

PR #450 landed three TS6133 unused-symbol errors; CI runs pnpm -r run typecheck, so main is currently red for every new PR. All three symbols are genuinely unreferenced (checked call sites — no dropped calls, comment-only references): writeOnboardingConfig import in credential_scanner.ts, writeWelcomeShown import in extension.ts, importSection local in onboarding_webview.ts. Mechanical removals, no behavior change. Full suite green on top of the fix.

Summary by CodeRabbit

• Chores
  • Removed unused internal references from the extension and onboarding components.
  • Improved test handling in environments without configured credentials.
  • No user-visible behavior or functionality has changed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2cc33fd6-e8d6-46a6-a6fd-ca5b5b932749

📥 Commits

Reviewing files that changed from the base of the PR and between e6623ac and f9258a4.

📒 Files selected for processing (1)

• packages/extension/test/credential_scanner.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes unused references from extension onboarding code and updates the credential scan test to skip its live assertion when no credentials are available.

Changes

Onboarding cleanup

Layer / File(s)	Summary
Remove unused references packages/extension/src/credential_scanner.ts, packages/extension/src/extension.ts, packages/extension/src/onboarding_webview.ts	Removes unused imports and the unused importSection DOM reference while retaining required logic.
Handle empty credential scans packages/extension/test/credential_scanner.test.ts	Skips the live credential assertion when the scan finds no credentials. Existing assertions remain unchanged when credentials are found.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f9258

This PR removes unused symbols to restore typechecking and does not change runtime behavior. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: jeonghun-jj-lee

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the typecheck fix and removal of unused symbols that caused the main branch failures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/main-typecheck-unused-symbols

---

_{Comment @coderabbitai help to get the list of available commands.}