fix(app): implement Cmd+A/Z/Shift+Z/Y editing shortcuts in framed editables - #126
Merged
Merged
Conversation
…les (#115) Extends the global editing fallback (patch #11) to cover select-all, undo, and redo — the same class of bug where native browser actions are suppressed by the VS Code/Electron platform layer inside the sandboxed iframe. - Cmd+A: selectAll via .select() (form fields) or Range.selectNodeContents (contenteditables) - Cmd+Z: document.execCommand('undo') - Cmd+Shift+Z / Cmd+Y: document.execCommand('redo') - Framed-context guard preserved (unframed windows keep native behavior) - Existing Cmd+V/C/X behavior unchanged - Shift modifier now allowed specifically for Cmd+Shift+Z (redo chord) Closes #115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the global editing fallback (patch #11's
installGlobalClipboardFallback) to cover select-all, undo, and redo — the same class of bug where native browser actions are suppressed by the VS Code/Electron platform layer inside the sandboxed iframe.Changes
packages/app/src/utils/global-clipboard.tsselectAll()helper:.select()for form fields,Range.selectNodeContentsfor contenteditablesinstallGlobalClipboardFallbackto handlea,z,ykeys in addition tov,c,xselectAll(target)document.execCommand('undo')document.execCommand('redo')event.shiftKeyspecifically for the redo chordpackages/app/src/utils/global-clipboard.test.tsAcceptance Criteria
http://127.0.0.1:{port}is unaffected (native behavior preserved)bun testpasses, typecheck greenCloses #115