Vault browsing: fail-closed by kind + public-only hackathon mode - #69
Merged
Merged
Conversation
…yment mode Aaron's review of the #65 gate: armonissima (kind=team, no browse key) browsed by default — orgs/, BUSINESS.md, partner-lab detail. Not hackathon-safe, and per-vault browse=false depends on remembering it. The marker taxonomy now decides: personal and public browse by default; team/project/engagement — and any unknown kind — ship dark until their marker opts in with browse = true. browse = false still darkens any kind. New AMICO_VAULT_BROWSER=public mode for the hackathon boxes: serves ONLY public mounts regardless of markers, and opens the deployment gate for their exposed binds. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-follow to the just-merged #65, per Aaron's review (armonissima —
kind = team, no browse key — browsed by default, reaching orgs/, BUSINESS.md, partner-lab detail).Fail-closed by construction, keyed on the marker taxonomy:
personalandpublicbrowse by default (operator's own machine / public by definition).team/project/engagement/ anything unknown ship dark until the marker saysbrowse = true— the deliberate opt-in Aaron asked for.browse = falsestill darkens any kind. The next team vault is covered automatically; nobody has to remember a flag.AMICO_VAULT_BROWSER=publicdeployment mode for the hackathon boxes: serves onlykind = publicmounts regardless of markers (and opens the deployment gate for their exposed binds).=0remains the total kill switch.Agent read grants unaffected throughout — this gates the panel's HTTP routes only. ADR 0003 updated. 38 vault tests green including the new kind-matrix and public-mode cases; opencode typecheck clean.
Not draft — Aaron asked for this before anything ships browsable-by-default, and the hackathon is the 29th.
🤖 Generated with Claude Code