Repository navigation
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #84
Description
On a self-hosted runner, the
nodebinary isn't in the path, making the wrapper run fail.In the related issue, there are several workarounds:
In my company, we have a shared workflow(using this action) that might run on GitHub-hosted runners or self-hosted runners, and I was hesitant to add a hack.
Looking for a solution I thought it would be nice to run the wrapper using the same node binary as this action does, so I decided to patch the first line of the wrapper to replace the
#!/usr/bin/env nodeshebang with the full path of action node which can be found atprocess.argv[0].I tested on my fork using a linux runners (GitHub and self-hosted), and it worked, but I'm unsure what will happen on Windows.
Rollback Plan