Replace an incomplete Odin grammar implementation - #4542
Open
marianpekar wants to merge 3 commits into
Open
marianpekar wants to merge 3 commits into
marianpekar wants to merge 3 commits into
Conversation
Build Size ReportChanges to minified artifacts in 4 files changedTotal change +1.24 KB View Changes
|
Build Size ReportChanges to minified artifacts in 4 files changedTotal change +1.26 KB View Changes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of months ago, I implemented Odin grammar support, but I was told to submit it as a third-party support package because submissions for new languages were no longer accepted. So I did (d301848)
Today, I found out that a PR from someone else to core was accepted, replacing my third-party package with a grammar implementation that isn't even complete (16d804c)
I've put a lot more effort into my implementation and it also includes complete markup test coverage. Since submissions to core are open again (I assume), I reviewed my original package (https://www.npmjs.com/package/highlightjs-odinlang), added a few missing built-ins, fixed a few minor issues, and prepared this PR.
I also write blog posts on my blog at https://marianpekar.com/, where I use highlighting for Odin extensively. This means I constantly test the implementation in production, and whenever I notice something is missing or Odin introduces something new that isn't covered, I'm ready to extend the implementation.
In other words, I'm personally invested in providing long-term support for this implementation because I'm effectively "my own customer."