does not detect file that has been deleted and recreated #122

Activity

1. chennqqi commented on Jul 2, 2017

   

   chennqqi

   on Jul 2, 2017

   More actions

   I test poll mode will trace delete and reopen ok. but Inotify does not

   👍React with 👍1Reacted by yayuntian
2. yayuntian commented on Jul 2, 2017

   

   yayuntian

   on Jul 2, 2017

   Author

   More actions

   hope fix Inotify
3. yutengwan commented on Jul 3, 2017

   

   yutengwan

   on Jul 3, 2017

   More actions

   我也遇到了这个问题，调试之后发现
   在 hpcloud/tail/vendor/gopkg.in/fsnotify.v1/inotify.go文件中，rm文件操作 默认走到了

   if mask&syscall.IN_ATTRIB == syscall.IN_ATTRIB {
           e.Op |= Chmod
    }
   

   这个逻辑上
   加上判断修改如下：

   if mask&syscall.IN_ATTRIB == syscall.IN_ATTRIB {
           _, statErr := os.Lstat(e.Name)
           if os.IsNotExist(statErr) {
               e.Op |= Remove
           } else {
               e.Op |= Chmod
           }
    }
   

   测试删除和然后新创建文件，然后新增内容可以获取到
4. yayuntian commented on Jul 16, 2017

   

   yayuntian

   on Jul 16, 2017

   Author

   More actions

   @yutengwan 提交merge request呀
5. anbaoyong commented on Aug 9, 2017

   

   anbaoyong

   on Aug 9, 2017

   More actions

   可以先用Poll的方式
6. luzhzhsoft commented on Sep 19, 2018

   

   luzhzhsoft

   on Sep 19, 2018

   Last edited by luzhzhsoft

   More actions

   @yayuntian @yutengwan 原因是这个。fsnotify/fsnotify#194

   试试修改下面fsnotify的代码。把忽略的消息放出来

   // If the event is not a DELETE or RENAME, the file must exist.
   // Otherwise the event is ignored.
   // *Note*: this was put in place because it was seen that a MODIFY
   // event was sent after the DELETE. This ignores that MODIFY and
   // assumes a DELETE will come or has come if the file doesn't exist.
   if !(e.Op&Remove == Remove || e.Op&Rename == Rename) {
   	_, statErr := os.Lstat(e.Name)
   	return os.IsNotExist(statErr)
   }