Skip to content

Fix streaming dataset features after map/add_column #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix streaming dataset features after map/add_column #8685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/datasets/iterable_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3744,7 +3744,10 @@ def _map(
is_batch_accumulate_arrow_table_function=is_batch_accumulate_arrow_table_function,
)
info = self.info.copy()
info.features = features
if features is not None:
info.features = features
elif remove_columns is not None and info.features is not None:
info.features = Features({k: v for k, v in info.features.items() if k not in remove_columns})
return IterableDataset(
ex_iterable=ex_iterable,
info=info,
Expand Down Expand Up @@ -4166,17 +4169,30 @@ def reshard(self) -> "IterableDataset":
token_per_repo_id=self._token_per_repo_id,
)

def add_column(self, name: str, column: Union[list, np.array]) -> "IterableDataset":
def add_column(self, name: str, column: Union[list, np.array], feature: Optional[FeatureType] = None) -> "IterableDataset":
"""Add column to Dataset.

Args:
name (str): Column name.
column (list or np.array): Column data to be added.
feature (`FeatureType` or `None`, defaults to `None`):
Column datatype.

Returns:
`IterableDataset`
"""
return self.map(partial(add_column_fn, name=name, column=column), with_indices=True)
if feature is None:
column_table = pa.Table.from_pydict({name: column})
new_features = Features.from_arrow_schema(column_table.schema)
else:
new_features = Features({name: feature})
info = self.info.copy()
if info.features is not None:
info.features = info.features.copy()
info.features.update(new_features)
else:
info.features = new_features
return self.map(partial(add_column_fn, name=name, column=column), with_indices=True, features=info.features)

def rename_column(self, original_column_name: str, new_column_name: str) -> "IterableDataset":
"""
Expand Down