Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DatasetInfosDict metadata overwrite
Summary
DatasetInfosDict.write_to_directory(..., overwrite=True)raisesAttributeError: 'dict' object has no attribute 'to_dataset_card_data'fornonempty input. The writer initializes its collection as a plain
dict; if alegacy
dataset_infos.jsonexists, it can update that file before crashing andleave the README metadata stale.
Initialize a
DatasetInfosDictand replace the README's existingdataset_infofield when overwriting. An empty overwrite now clears oldconfiguration metadata while preserving other card metadata and description.
Validation
layouts, new/existing/empty configurations, merge and overwrite behavior,
multiple configurations, and preservation of unrelated card content. The
new tests exposed 11 failures before the fix.
tests/test_info.py tests/test_metadata_util.py: 50 passed on both Python3.10.21 and 3.14.7.
requiring unavailable symlink privileges excluded.
The broader Windows run excluding CI Hub tests completed with 3,399 passed,
258 skipped, 4 integration failures, and 3 symlink setup errors. Those failures
did not enter the changed writer; they involved missing
torchcodec, asubprocess using base Python, an old cache hash expectation, and Windows
symlink privileges. The CI Hub module stalled on a cleanup request without a
timeout, so a clean full-suite result is not available locally.