Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8706.
After
skip()ortake(), iterating anIterableDatasetat a nonzero epoch currently raisesDataSourcesShufflingDisallowed. Preserve the frozen shard order during epoch preparation, while still updating shuffle-buffer RNGs.Shift RNGs on shallow copies of the iterable wrappers so the stored pipeline remains reusable. Otherwise, handling the exception alone makes repeated iterations of the same epoch produce different orders.
Validation on
mainatfa995bdaea171d50d086743364f23e9db6b557d8:skip/take, fixed shard order, and repeatable epoch transitions through a nestedmapwrapper.tests/test_iterable_dataset.py: 516 passed, 31 skipped, 2 Hub-loading failures in offline mode. Both failures passed when rerun online (2 passed).make qualityandgit diff --checkpass. The released 5.0.1 also reproduces the original exception.AI assistance: Codex assisted with the investigation, patch, tests, and PR text. The checks above were run locally.