Repository navigation
Use explicit nn.Buffer everywhere for modular - #47722
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: afmoe, aimv2, albert, align, altclip, apertus, arcee, aria, axk1, axk2, bamba, bark, bart, bert, bert_generation, big_bird |
Contributor
CI recapDashboard: View test results in Grafana |
ArthurZucker
approved these changes
Aug 3, 2026
vasqu
approved these changes
Aug 3, 2026
vasqu
left a comment
vasqu
left a comment
Collaborator
There was a problem hiding this comment.
Maybe we should add an mlinter rule for this now? Should be fairly straightforward
I.e. automatically reject register buffer calls
Collaborator
b-re-w
added a commit
to latentforge/transformers-tts
that referenced
this pull request
Sep 6, 2026
The generated `modeling_*.py` files for qwen3_tts and its two audio tokenizers were last produced on 2026-06-30 and had drifted from the parent models they inherit from (qwen3, qwen2_5_omni, qwen3_omni_moe, mimi). Re-running `utils/modular_model_converter.py` picks up those changes: `nn.Buffer` instead of `register_buffer` (huggingface#47722), the `inv_freq` linting annotation removal (huggingface#47753), the kernel decorator rename to `use_kernel_forward_from_hub` (huggingface#46883), the Token2Wav DiT interleaved-RoPE fix (huggingface#47403), removal of the legacy FlashAttention2 / SdpaAttention classes, and assorted spelling fixes (huggingface#47684). Three fixes were needed in the modular sources so that regeneration does not regress behaviour: - Move `Qwen3TTSConfig.get_text_config` into `modular_qwen3_tts.py`. It had only ever been added to the generated configuration file, so the converter dropped it. - Pin `Qwen3TTSTalkerModel._no_split_modules` to `["Qwen3TTSTalkerDecoderLayer"]`. The converter resolves the inherited value with the most common prefix (`Qwen3TTS`) and would otherwise point at the wrong decoder layer class. - Add a `Qwen3TTSTokenizerMultiCodebookSnakeBeta` alias and use it in the code2wav decoder. Upstream renamed `SnakeBeta` to `Qwen2_5OmniSnakeBeta`, which left an undefined `SnakeBeta` reference in the generated file. Conversion is idempotent, `ruff check` / `ruff format --check` pass, and all touched files compile. Claude-Session: https://claude.ai/code/session_01WLU94QdJCmuVf181X98tno
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. SInce we upgraded to torch>=2.5 recently, we can use the
nn.Bufferclass to register a buffer, similar to usingnn.Parameterto register a custom param. This makes it much easier for modular, as we can start inheriting buffers and slightly modify them as it's a simple attribute, instead of having to redefine the whole__init__