Skip to content

test(st): drop a5 from runtime_fatal_codes onboard coverage - #1206

Merged
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
doraemonmj:drop-a5-runtime-fatal-codes
Jun 30, 2026
Merged

ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
doraemonmj:drop-a5-runtime-fatal-codes

Conversation

@doraemonmj

Copy link
Copy Markdown
Contributor

The onboard device-error test (test_device_error_class_reaches_host_log) now runs on a2a3 only; a5 is taken offline.

The sim test (a5sim/a2a3sim) is unchanged.

The onboard device-error test now runs on a2a3 only; a5 is taken offline.
The sim test (a5sim/a2a3sim) is unchanged.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 93d5192b-41b9-48ae-ab7d-41576d6584b4

📥 Commits

Reviewing files that changed from the base of the PR and between 0a5e25c and 784f4f7.

📒 Files selected for processing (1)
  • tests/st/runtime_fatal_codes/test_runtime_fatal_codes.py

📝 Walkthrough

Walkthrough

The @pytest.mark.platforms decorator for test_device_error_class_reaches_host_log is changed to remove a5, restricting the test to a2a3 only.

Changes

Platform Restriction for Hardware Fatal-Code Test

Layer / File(s) Summary
Remove a5 from test platform decorator
tests/st/runtime_fatal_codes/test_runtime_fatal_codes.py
@pytest.mark.platforms for the onboard hardware fatal-code classification test is updated from a2a3, a5 to a2a3 only.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hopped by and said with a grin,
"Let a5 sit this test out—don't let it in!
Only a2a3 shall run this today,
One platform is plenty, hip-hip-hooray!" 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing a5 from onboard runtime_fatal_codes coverage.
Description check ✅ Passed The description is directly related to the change and accurately notes the onboard test now runs on a2a3 only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test suite in test_runtime_fatal_codes.py by removing the 'a5' platform from the @pytest.mark.platforms decorator for a specific test case, limiting its execution to the 'a2a3' platform. There are no review comments provided, and I have no additional feedback on this change.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ChaoZheng109
ChaoZheng109 merged commit 640a59f into hw-native-sys:main Jun 30, 2026
16 checks passed
@doraemonmj
doraemonmj deleted the drop-a5-runtime-fatal-codes branch August 3, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants