feat(dfx): capture early-dispatch flag in dep_gen, badge it in deps_viewer - #1340
Conversation
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a8c2111 to
5e41a12
Compare
…iewer dep_gen never recorded whether a submit was a flagged early-dispatch producer (allow_early_resolve), so the dependency graph could not show which tasks drive early dispatch — the key scheduling attribute behind the a2a3 sync_start cohorts. Capture path: - `DepGenRecordFlags` gains `DEP_GEN_FLAG_EARLY_DISPATCH` (a2a3 + a5). - `dep_gen_aicpu_record_submit` takes an `early_dispatch` arg and sets the flag; the orchestrator passes `args.allow_early_resolve()` (a2a3 tmr + host_build_graph). a5 tmr has no early-dispatch, so it passes false. - `dep_gen_replay` reads the flag and emits `"early_dispatch":<bool>` per task in deps.json (a2a3 + a5, tmr + hbg). Visualization (`deps_viewer.py`): - 🔥 badge: the task itself is a flagged early-dispatch producer. - ⭐ badge: every predecessor of the task is flagged (and it has ≥1), so it is fully fed by flagged producers. - A task can carry both (🔥⭐). Badges prefix the node label in both the plain and rich (HTML-table) DOT node renderers. Verified onboard: a 2-layer qwen3-14B decode deps.json flags 188/646 tasks; the HTML graph shows 🔥 on flagged producers and ⭐ on fully-flagged-fed consumers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for tracking and visualizing "early dispatch" tasks (flagged producers) in the dependency generator and viewer. It adds an early_dispatch flag to task submission records, propagates this flag through the replay mechanism into the generated deps.json file, and updates the dependency viewer tool (deps_viewer.py) to display visual markers (🔥 for early-dispatch tasks and ⭐ for tasks fully fed by early-dispatch predecessors) and active function names on the nodes. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…iewer (hw-native-sys#1340) dep_gen never recorded whether a submit was a flagged early-dispatch producer (allow_early_resolve), so the dependency graph could not show which tasks drive early dispatch — the key scheduling attribute behind the a2a3 sync_start cohorts. Capture path: - `DepGenRecordFlags` gains `DEP_GEN_FLAG_EARLY_DISPATCH` (a2a3 + a5). - `dep_gen_aicpu_record_submit` takes an `early_dispatch` arg and sets the flag; the orchestrator passes `args.allow_early_resolve()` (a2a3 tmr + host_build_graph). a5 tmr has no early-dispatch, so it passes false. - `dep_gen_replay` reads the flag and emits `"early_dispatch":<bool>` per task in deps.json (a2a3 + a5, tmr + hbg). Visualization (`deps_viewer.py`): - 🔥 badge: the task itself is a flagged early-dispatch producer. - ⭐ badge: every predecessor of the task is flagged (and it has ≥1), so it is fully fed by flagged producers. - A task can carry both (🔥⭐). Badges prefix the node label in both the plain and rich (HTML-table) DOT node renderers. Verified onboard: a 2-layer qwen3-14B decode deps.json flags 188/646 tasks; the HTML graph shows 🔥 on flagged producers and ⭐ on fully-flagged-fed consumers.
Bring a5 tensormap_and_ringbuffer in line with a2a3 early-dispatch (hw-native-sys#989/hw-native-sys#1079/hw-native-sys#1285/hw-native-sys#1288/hw-native-sys#1297/hw-native-sys#1304/hw-native-sys#1326/hw-native-sys#1329/hw-native-sys#1336/hw-native-sys#1405/hw-native-sys#1340): prepare/publish, src_payload gate + DMB high32 doorbell (sim uses __atomic_load_n ACQUIRE), direct-only eligibility, spare-slot Phase 4b, sync_start early rendezvous, and dep_gen early_dispatch truth. Document the a5 model in RUNTIME_LOGIC §8.6. Add a5 STs: plain early_dispatch plus sync_start early_dispatch and mix_spill ports (EarlyOn/Off) for board validation.
) * feat(a5/tmr): port allow_early_resolve / early-dispatch from a2a3 Bring a5 tensormap_and_ringbuffer in line with a2a3 early-dispatch (#989/#1079/#1285/#1288/#1297/#1304/#1326/#1329/#1336/#1405/#1340): prepare/publish, src_payload gate + DMB high32 doorbell (sim uses __atomic_load_n ACQUIRE), direct-only eligibility, spare-slot Phase 4b, sync_start early rendezvous, and dep_gen early_dispatch truth. Document the a5 model in RUNTIME_LOGIC §8.6. Add a5 STs: plain early_dispatch plus sync_start early_dispatch and mix_spill ports (EarlyOn/Off) for board validation. * test(a5): drop local early-dispatch ST ports from this PR Remove the a5-only early_dispatch / sync_start early ST scenes added for board experiments; keep the runtime port focused for CI. * chore(a5): drop unrelated files that broke pre-commit on the PR Remove accidental local helpers, migrate patches, and the acc_c2v example that were committed with the UT payload-pool fix. Keep the early-dispatch runtime port, a2a3-ported sync_start STs, and a5 UT payload/task pool binding.
1 participant
What
Makes the early-dispatch attribute of tasks visible in the dependency graph. dep_gen never recorded whether a submit was a flagged early-dispatch producer (
allow_early_resolve), sodeps_viewercouldn't show which tasks drive early dispatch — the key scheduling signal behind the a2a3sync_startcohorts.Capture path (runtime)
DepGenRecordFlagsgainsDEP_GEN_FLAG_EARLY_DISPATCH(a2a3 + a5).dep_gen_aicpu_record_submittakes anearly_dispatcharg and sets the flag; the orchestrator passesargs.allow_early_resolve()(a2a3 tmr + host_build_graph). a5 tmr has no early-dispatch, so it passesfalse.dep_gen_replayreads the flag and emits"early_dispatch":<bool>per task indeps.json(a2a3 + a5, tmr + hbg).Visualization (
deps_viewer.py)Testing
Verified onboard: a 2-layer qwen3-14B decode
deps.jsonflags 188/646 tasks; the HTML graph shows 🔥 on flagged producers (e.g.🔥 (3, 3) · q_proj), ⭐ on fully-flagged-fed consumers, and 🔥⭐ where both hold. simpler rebuilt clean (a2a3 + a5); pre-commit (clang-format/tidy/cpplint/ruff/pyright) clean.🤖 Generated with Claude Code