Skip to content

CI: run A5 SDMA tests on x86 - #1760

Merged
ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
doraemonmj:support/run-a5-sdma-tests-on-x86
Aug 11, 2026
Merged

ChaoZheng109 merged 1 commit into
hw-native-sys:mainfrom
doraemonmj:support/run-a5-sdma-tests-on-x86

Conversation

@doraemonmj

Copy link
Copy Markdown
Contributor

Summary

  • Run the full A5 onboard scene-test corpus, including SDMA, on x86_64 and ARM64 runners.
  • Remove the A5 x86_64 not sdma marker filter while preserving the A2/A3 SDMA isolation policy.
  • Update CI and testing documentation to match the runner capability.

Testing

  • Pre-commit hooks passed.
  • Workflow YAML and Markdown lint passed.
  • Hardware tests not run locally; the updated A5 CI job exercises the full corpus.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6893cda-44f4-477d-8fd0-e67f0c73382e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

A5 scene-test execution now runs the complete pytest corpus, including SDMA tests, on x86_64 and ARM64. The workflow, CI documentation, testing guide, and testing skill now use one consistent command.

Changes

A5 SDMA execution

Layer / File(s) Summary
Run the full A5 test corpus
.github/workflows/_st-npu-a5.yml
The workflow submits pytest directly through task-submit without the x86_64 sdma exclusion.
Align CI and testing guidance
.claude/skills/testing/SKILL.md, docs/ci.md, docs/testing.md
The guidance states that A5 runs the complete corpus on both architectures. It retains the separate SDMA step for a2a3.
Estimated code review effort: 2 (Simple) ~10 minutes

Possibly related PRs

Poem

A5 runs every test in line,
SDMA joins the pytest shine.
x86 and ARM agree,
One command hops so happily.
— A reviewing rabbit 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the A5 SDMA CI change, but it omits the ARM64 scope and full-corpus change.
Description check ✅ Passed The description clearly covers the A5 SDMA CI change, preserved A2/A3 policy, documentation updates, and testing status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@doraemonmj
doraemonmj force-pushed the support/run-a5-sdma-tests-on-x86 branch 2 times, most recently from 3cc45ce to a48ea23 Compare August 11, 2026 01:48
@ChaoZheng109

Copy link
Copy Markdown
Collaborator

The A5 marker-selection wording is still inconsistent in two testing skills:

  • .claude/skills/test-all-device/SKILL.md says st-onboard-a5 has no marker filter.
  • .claude/skills/test-runtime-device/SKILL.md says the same.

After this PR, the A5 workflow still uses -m "not pod"; it only stops excluding sdma. Saying there is no marker filter can make local/agent reproductions run the pod tests in the ordinary single-machine A5 sweep.

Could we update both skills to say something like: st-onboard-a5 uses -m "not pod" and does not exclude sdma?

@doraemonmj
doraemonmj force-pushed the support/run-a5-sdma-tests-on-x86 branch from a48ea23 to 9e6c6a5 Compare August 11, 2026 03:25
@doraemonmj

Copy link
Copy Markdown
Contributor Author

@ChaoZheng109 Addressed — both testing skills now state that st-onboard-a5 uses -m "not pod" without excluding sdma, and include matching A5 command examples.

Remove the x86_64 marker filter from A5 onboard scene tests now that
the runner supports SDMA. Keep the A2/A3 isolation policy unchanged
and update CI and testing documentation to match.
@doraemonmj
doraemonmj force-pushed the support/run-a5-sdma-tests-on-x86 branch from 9e6c6a5 to 3b11037 Compare August 11, 2026 06:09
@ChaoZheng109
ChaoZheng109 merged commit ecbc2ee into hw-native-sys:main Aug 11, 2026
19 checks passed
@doraemonmj
doraemonmj deleted the support/run-a5-sdma-tests-on-x86 branch August 31, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants