Skip to content

Update: remove host and device clock anchors - #2218

Open
doraemonmj wants to merge 1 commit into
hw-native-sys:mainfrom
doraemonmj:feat/remove-host-device-anchors
Open

doraemonmj wants to merge 1 commit into
hw-native-sys:mainfrom
doraemonmj:feat/remove-host-device-anchors

Conversation

@doraemonmj

Copy link
Copy Markdown
Contributor

Summary

  • remove host CLOCK_ANCHOR emission and host/device clock-correlation capture lifecycle
  • remove the public capture_clock_anchors option and anchor-derived trace metadata
  • keep host_clock_domain_id for host-phase captures, and update affected tests and documentation

Testing

  • Python UT: 2273 passed, 24 skipped
  • affected Python cases: 127 passed
  • non-hardware C++ UT: 144/144 passed
  • targeted chip swimlane collector C++ test: passed
  • pre-commit checks: passed
  • all four platform editable builds: passed
  • A2/A3 onboard level-4 chip swimlane (HBG and TRB): 5 pytest cases passed, 8 capture JSONs verified anchor-free (task_20260913_194032_27955871017)

A5 onboard hardware was not available on this host.

- Remove CLOCK_ANCHOR emission and host/device clock-correlation capture
- Drop the public capture option and anchor metadata from trace exports
- Update lifecycle code, tests, and documentation for anchor-free capture
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a200dc9b-de34-4a0a-91da-73ab896884d7

📥 Commits

Reviewing files that changed from the base of the PR and between 748c39f and 2c11fd5.

📒 Files selected for processing (48)
  • docs/dfx/chip-swimlane-profiling.md
  • docs/dfx/device-phases.md
  • docs/dfx/hbg-bind-phases.md
  • docs/dfx/host-trace.md
  • docs/logging.md
  • docs/task-flow.md
  • docs/user/reference/python-api.md
  • python/bindings/task_interface.cpp
  • python/simpler/worker.py
  • simpler_setup/tools/containment.py
  • simpler_setup/tools/strace_timing.py
  • src/a2a3/platform/onboard/host/CMakeLists.txt
  • src/a2a3/platform/onboard/host/device_runner.cpp
  • src/a2a3/platform/sim/host/CMakeLists.txt
  • src/a2a3/platform/sim/host/device_runner.cpp
  • src/a5/platform/onboard/host/CMakeLists.txt
  • src/a5/platform/onboard/host/device_runner.cpp
  • src/a5/platform/sim/host/CMakeLists.txt
  • src/a5/platform/sim/host/device_runner.cpp
  • src/common/hierarchical/remote_wire.cpp
  • src/common/log/host_log.cpp
  • src/common/log/include/common/host_log_state.h
  • src/common/log/include/host_log.h
  • src/common/platform/include/host/chip_swimlane_collector.h
  • src/common/platform/include/host/clock_correlation.h
  • src/common/platform/include/host/dfx_run_config.h
  • src/common/platform/include/host/host_phase_run_state.h
  • src/common/platform/onboard/host/c_api_shared.cpp
  • src/common/platform/onboard/host/clock_correlation.cpp
  • src/common/platform/onboard/host/device_runner_base.cpp
  • src/common/platform/onboard/host/device_runner_base.h
  • src/common/platform/shared/host/chip_swimlane_collector.cpp
  • src/common/platform/shared/host/clock_correlation.cpp
  • src/common/platform/sim/host/c_api_shared.cpp
  • src/common/platform/sim/host/clock_correlation.cpp
  • src/common/platform/sim/host/device_runner_base.cpp
  • src/common/platform/sim/host/device_runner_base.h
  • src/common/task_interface/call_config.h
  • tests/st/a2a3/host_build_graph/concurrent_prepare_stress/test_concurrent_prepare_stress.py
  • tests/ut/cpp/CMakeLists.txt
  • tests/ut/cpp/a5/test_host_log_off.cpp
  • tests/ut/cpp/common/test_sim_device_log.cpp
  • tests/ut/cpp/types/test_call_config.cpp
  • tests/ut/py/test_chip_worker.py
  • tests/ut/py/test_host_timing_is_strace_only.py
  • tests/ut/py/test_strace_timing.py
  • tests/ut/py/test_swimlane_converter.py
  • tests/ut/py/test_worker/test_host_worker.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant