chore: bump @hyperdx/node-logger + @hyperdx/node-opentelemetry pkgs#5
Merged
Conversation
|
mlsalcedo
pushed a commit
to mlsalcedo/hyperdx
that referenced
this pull request
Feb 27, 2026
Upgrade to ver 2.7.1
4 tasks
knudtty
pushed a commit
that referenced
this pull request
Apr 16, 2026
abhiroop93
added a commit
to ShareChat/hyperdx
that referenced
this pull request
Apr 28, 2026
…026-04-28 customizations 1-8 implemented and verified: - #1 live tail feature flag + configurable duration - #2 autocomplete top-N display (pagination removed) - hyperdxio#3 per-keystroke clickhouse prefix search + includes() filtering + configurable date range (NEXT_PUBLIC_AUTOCOMPLETE_DATE_RANGE_MS) - hyperdxio#4 privileged-user access gate for team settings - hyperdxio#5 standard otel sdk exporter for app self-telemetry - hyperdxio#6 google sso with domain auto-join; sso button above email/password form - hyperdxio#7 next-runtime-env standalone __ENV.js generation at container startup - hyperdxio#8 live tail configurable refresh interval (15m/30m/1h)
alex-fedotyev
added a commit
that referenced
this pull request
May 6, 2026
The three failing dashboard-container tests in CI shard 1 came down to two distinct races: 1. Tests #3 (line 112) and #5 (line 194) read getActiveTabsParam()[id] synchronously after Add Tab and after tab switches. nuqs flushes URL state asynchronously, so the read fires before the param is written. Wrap each sync read in expect.poll, mirroring the fix in PR #2209. 2. Test #6 (line 231) paired toggleGroupBordered(idA) with addTabToGroup(idB) back-to-back. Both setDashboard calls produce() from the same pre-mutation snapshot of the React Query cache, so the second PATCH overwrites the first; the toggle is silently dropped. The save-and-reload assertion then sees the wrong state (or, when goto fires before the PATCH lands, no state at all). Narrow the round-trip to a single mutation per step (addTabToGroup on group B), wait for networkidle before navigating away, capture the dashboard id from the URL while we are still on the page, and use expect.poll for the post-reload getGroupOrder assertion. The bordered toggle stays covered by the dedicated in-page test at line 78. The underlying back-pressure race is tracked separately in #2216.
6 tasks
4 tasks
alex-fedotyev
added a commit
that referenced
this pull request
May 8, 2026
The three failing dashboard-container tests in CI shard 1 came down to two distinct races: 1. Tests #3 (line 112) and #5 (line 194) read getActiveTabsParam()[id] synchronously after Add Tab and after tab switches. nuqs flushes URL state asynchronously, so the read fires before the param is written. Wrap each sync read in expect.poll, mirroring the fix in PR #2209. 2. Test #6 (line 231) paired toggleGroupBordered(idA) with addTabToGroup(idB) back-to-back. Both setDashboard calls produce() from the same pre-mutation snapshot of the React Query cache, so the second PATCH overwrites the first; the toggle is silently dropped. The save-and-reload assertion then sees the wrong state (or, when goto fires before the PATCH lands, no state at all). Narrow the round-trip to a single mutation per step (addTabToGroup on group B), wait for networkidle before navigating away, capture the dashboard id from the URL while we are still on the page, and use expect.poll for the post-reload getGroupOrder assertion. The bordered toggle stays covered by the dedicated in-page test at line 78. The underlying back-pressure race is tracked separately in #2216.
9 tasks
kodiakhq Bot
pushed a commit
that referenced
this pull request
May 26, 2026
…drag) (#2205) ## Summary Follow-up E2E coverage for PR #2015 (the unified `DashboardContainer` that replaced the legacy section/group concept). Drew explicitly asked for this in his top-level review on #2015 ("Can you confirm we have followup issues/tickets covering... 2. New E2E tests covering the new functionality"). Unit coverage landed in #2015 itself; this PR adds the missing browser-level coverage. The container UX has four moving pieces, all exercised here: collapsible (chevron + URL state), bordered (overflow-menu toggle + inline border style), tabs (tab bar appearance, tab switching, URL state), and drag-to-reorder via @dnd-kit. Each test step cites the source line that defines the behavior so a reviewer can double-check the assertion matches the implementation. ### Test cases 1. Group renders with default collapsible chevron and bordered style; chevron toggles `aria-expanded`. 2. Toggling Hide Border / Show Border via the overflow menu flips the inline border style and the menu label. 3. Adding a tab brings the tab bar (1-tab groups don't render it), switching tabs updates `?activeTabs` and `aria-selected`. 4. `?collapsed` and `?expanded` URL params survive reload and restore per-viewer state. 5. `?activeTabs` URL param survives reload and restores the active tab. 6. Save-and-reload round-trip preserves the containers list and the second tab on group B. 7. Drag-to-reorder: drag-onto-self is a no-op (the DnD guard at `DashboardDndContext.tsx:67-70`); dragging A onto C in `[A, B, C]` yields `[B, C, A]` (arrayMove semantics) and the new order persists across navigation. ### What changed since the first push - Tests #3 and #5 wrap `getActiveTabsParam()[id]` reads in `expect.poll(...)` because `nuqs` flushes URL state asynchronously after `Add Tab` and tab switches. This is the same race pattern the heatmap drag-select e2e (PR #2209) hit. - Test #6 was narrowed to a single mutation per step (`addTabToGroup` on group B) and now waits for `networkidle` before navigating away. The earlier version paired a `toggleGroupBordered(idA)` with `addTabToGroup(idB)` back-to-back; the resulting concurrent `setDashboard` calls clobber each other because the second `produce` reads the same pre-mutation snapshot. That underlying race is tracked in #2216. Bordered round-trip is still covered in isolation by test #2. ### Side fixes pulled in - `DashboardPage.ts` page-object selector was still pointing at the stale `add-new-section-menu-item` testid; PR #2015 renamed it to `add-new-group-menu-item`. No existing spec exercised `addSection`, so this hadn't surfaced. Renamed the locator and the helper from `addSection` -> `addGroup`. - `DashboardContainer.tsx` adds `data-testid="group-add-tab-${id}"` on the existing Add Tab menu item so the spec doesn't have to match Mantine menu text. One-line non-behavior change. ### Tier Predicted **Tier 2** by the local classifier: 1 production file, 10 production lines (the testid addition), no API/router/model touch, single-layer (`packages/app/`). Test files are excluded from the tier calculation per the classifier rules. ### Out of scope - Concurrent-mutation back-pressure on `setDashboard` (PATCH clobber). Tracked in #2216. - Multi-user URL state isolation (covered by `dashboardSections.test.tsx` unit tests). - Alert-dot indicators (covered by `DashboardContainer.test.tsx`). - Legacy `type: "section"` migration (one-time data shape; covered by `dashboardSections.test.tsx`). - Tile drag-reorder (uses `react-grid-layout`, not the new `@dnd-kit` container DnD). ## Test plan - [x] `yarn lint` clean. - [x] `yarn tsc --noEmit` clean. - [x] `npx playwright test --list tests/e2e/features/dashboard-container.spec.ts` lists all 7 cases. - [x] `prose-lint` clean against `origin/main`. - [x] Local tier prediction: **Tier 2**. - [ ] CI: full E2E shard run on this branch. Refs PR #2015. Follow-up race tracked in #2216.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.