Skip to content

Promote plan cards and stuck-question fix to bkt3 (#319, #320) - #321

Merged
bk-agent-01 merged 8 commits into
bkmainfrom
promote/plan-cards-stuck-questions-2026-10-16
Oct 16, 2026
Merged

bk-agent-01 merged 8 commits into
bkmainfrom
promote/plan-cards-stuck-questions-2026-10-16

Conversation

@bk-agent-01

Copy link
Copy Markdown
Collaborator

This PR promotes two stage PRs to bkt3 production. Tushar asked for this promotion at 11:00 IST on 16 October 2026.

What it ships

  • PR #319: the plan cards render like chat. They can go wide, show live HTML, and take Cite and comments. The Preview button is gone. The BK sidebar drops the PLAN tag once plan mode is off.
  • PR #320: a question or approval left by a failed run can be answered or dismissed. Today, three questions on bkt3 are stuck this way.

Both PRs run on stagebkt3 now (96d91ea). Tushar confirmed on staging that plan mode works.

How it was built

stage also carries PR #317 (TEC-1331), which belongs to another session. This branch leaves #317 out. It starts from origin/bkmain and cherry-picks only the eight commits of #319 and #320 (with -x). Every commit applied cleanly. The fork-marker check passes on the branch.

Effect of the merge

The merge deploys bkt3. The restart stops every live session on bkt3 for about a minute. That is why the merge waits for the agreed time.

How I tested

  • The same commits passed all CI checks on the two stage PRs, and they run on stagebkt3.
  • CI runs again on this branch, because it sits on bkmain, which carries PostHog and promotion commits that stage does not have.
  • After the merge, I check deployed-sha and the service state, and that the three stuck questions accept Submit and Dismiss.

🤖 Generated with Claude Code

bk-agent-01 and others added 8 commits October 15, 2026 19:17
A thread kept its PLAN pill, Plan Ready group and needs-human count for as
long as its plan stayed active, even after plan mode was turned off. A plan
now waits only while its thread is in plan mode, matching upstream's Plan
Ready rule, so stale tags clear without a migration.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e925a5b)
- Remove the plan card's Preview button; Expand plan stays.
- New header: icon, title, state, step count, reading time, and a
  Widen plan toggle that lets cards use the free width beside the chat.
- Plan bodies get the chat's markdown features (skills, runnable shell
  commands, image preview, artifact templates).
- HTML in a plan renders as a live themed page, like html_render: a whole
  HTML plan, a raw HTML document, or an html-render fence.
- Selecting plan text offers Cite and the comment actions; highlights,
  pins and scroll-to-quote work on plans, and the panel labels them.
- Plan-mode turns tell the agent how to add an html-render visual.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 0d14438)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit a0d2255)
- The plan-format hint joins the fork's plan policy only when plan
  submission is off, so provider replays keep their recorded input.
- Compare a citation's message id with the plan id as plain strings.
- Type the comments panel's message list so plans can join it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 9e3b3f8)
- Plan HTML loads inline through srcDoc, so a frame opened on its own
  cannot run with the app's origin. The reader's theme is written into
  the page for the first paint and posted on change.
- A remounted plan page starts at its last measured height, so the
  virtualised list does not jump.
- A wide card starts after the timeline minimap's clickable strip.
- Plan cards read a memoised slice of the timeline state.
- Comment gutter bars sit in the card padding, not over the text.
- Settings and docs no longer point at the removed Preview button.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 0901743)
…smissed

When a run fails while the agent waits on a question (the provider stream
closes, an event fails to ingest), the run ends and its provider session is
detached, but the question stays pending with a live capability. Submit then
failed with "Provider session ... was not found", dismiss failed with
"This question needs an answer", and Stop was gone.

A request whose session is detached or whose run has ended is now handled in
message mode: an answer resolves it and reaches the agent as the next
message, a dismissal closes it, and an approval closes without a reply. The
composer marks such a question dismissible. Multi-select answers join their
choices when sent as a message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit e8ee65f)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 2a6abc8)
- A completed run no longer counts as ended: its session stays live and a
  background subagent can still wait on an approval. Failed, interrupted
  and cancelled runs do.
- Read only the request's own run, and take it from the timeline item when
  the node has none.
- MCP lists a question whose run failed or stopped as non-blocking, so
  t3_answer can dismiss it and t3_send_message no longer refuses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 56e1306)
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Oct 15, 2026
@bk-agent-01
bk-agent-01 merged commit 6d04dc4 into bkmain Oct 16, 2026
25 of 26 checks passed
@bk-agent-01

Copy link
Copy Markdown
Collaborator Author

Merged at 11:00 IST on 16 Oct 2026, pinned to head b1e5f22, on Tushar's go in the owning T3 session ("promote to bkmain at 11 am tomorrow"). All checks were green on that head. Deploy check follows at 11:45 IST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant