Repository navigation
fix(server): storage cleanup handles newer git's broken-gitfile error - #357
Merged
Merged
Conversation
…like a missing repository Newer git (on the GitHub runners since 2026-10-28) prints "fatal: gitfile does not point to a valid repository" where older git printed "not a git repository". The branch check then reported the worktree as failed instead of kept, and storageCleanup.test.ts "compares the checked-out branch without a full status" failed on every stage branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
Collaborator
Author
|
Merge decision: tushar chose "AI fixes it" for this test in the T3 session on 2026-10-29. Head 18b6876, all checks green. Cross-review skipped (one-line error-text match, proven by the failing test now passing). |
This was referenced Oct 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs TEC-1624
Summary
stagefails one test:src/storageCleanup.test.ts› "compares the checked-out branch without a full status"..gitpoints to a missing folder, that git printsfatal: gitfile does not point to a valid repository. Older git printednot a git repository.storageCleanup.tsknew only the old text, so it reported the worktree asfailed. The test expectskept("Repository or branch changed").T3-CUSTOM(expbkt3)) in an upstream-owned file.40705333893(PR feat(server): scheduled and webhook prompts steer a busy session by default #354),40739549318(PR feat(server): compact agent-toolkit session output and full ids in next-call hints (TEC-1818) #355, twice) and40745857718(PR feat(server): MCP errors that say what to send, and idempotent archive (TEC-1819) #356).This fix unblocks bkt3 PRs #355 and #356 (TEC-1818, TEC-1819). Tushar chose "AI fixes it" in the T3 session on 2026-10-29.
Decisions
Acceptance check
storageCleanup.test.tspasses on CIHow I tested
No local tests on the shared host. CI runs the server test shards.
Cross-review: skipped — a one-line string match in an error path, proven by the existing failing test.
🤖 Generated with Claude Code