feat: make catalog_path configurable in plot_catalog function for 4FDGL Fermi catalog#60
Conversation
G-Sommani
left a comment
There was a problem hiding this comment.
@ric-evans, do you know why so many checks are failing? For sure it is not because of this modification.
thanks @G-Sommani for pointing this out. |
|
back from vacation -- I'll fix these failures in another branch |
|
@tianluyuan I realized I need to update also https://github.com/icecube/skyreader/blob/main/skyreader/plot/plot.py to allow the user to properly pass the catalogh path variable. |
|
Now the branch contains all the changes I need. |
The branch is auto-deleted when the PR merges. You would need to create a new branch from |
ok thanks :) I didn't know |
Following the previous [pull request](#60), this change has been made: _catalog_path_ is passed directly as an argument to the functions in _plot.py,_ which are the ones actually used by Skymist and with which it can interact
This PR introduces an optional
catalog_pathargument in theplot_catalogfunction.This change is particularly crucial for Docker containers that automatically process track alerts:
CATALOG_PATH.plot_catalogflexibly (e.g. for plotting 4FGL). Indeed, up to now we’ve had to run this functionality manually in our own Condor spaces. With the proposed change, Docker containers will be able to automatically generate plots with Fermi gamma-ray sources overplotted on the best-fit direction and map.Benefits