Skip to content

Fix #3820: decompile dynamic ~ as ~x instead of an unsupported-opcode error #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siegfriedpammer merged 4 commits into from
Jun 26, 2026
Merged

Fix #3820: decompile dynamic ~ as ~x instead of an unsupported-opcode error #3822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76d5023
Fix #3820: decompile dynamic ~ as ~x instead of an unsupported-opcode…
sailro Jun 26, 2026
2611206
Exercise dynamic unary operators in the correctness suite
christophwille Jun 26, 2026
5be3ac7
Cover dynamic bitwise, shift, and modulo compound assignments
christophwille Jun 26, 2026
1d848a2
Cover dynamic bitwise and shift binary operators
christophwille Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ICSharpCode.Decompiler.Tests/TestCases/Correctness/DynamicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ static void Main(string[] args)
PrintResult((ref dynamic x) => x = x / 2.0, 5);
PrintResult((ref dynamic x) => x = x / 2, 5.0);
PrintResult((ref dynamic x) => x = x / 2, 5);
PrintResult((ref dynamic x) => x = ~x, 5);
PrintResult((ref dynamic x) => x = -x, 5);
PrintResult((ref dynamic x) => x = +x, 5);
PrintResult((ref dynamic x) => x = !x, true);
}

private static void PrintResult(RefAction<dynamic> p, dynamic arg)
Expand Down
24 changes: 24 additions & 0 deletions ICSharpCode.Decompiler.Tests/TestCases/Pretty/DynamicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,23 @@ private static void UncheckedArithmeticBinaryOperators(dynamic a, dynamic b)
}
}

private static void BitwiseAndShiftBinaryOperators(dynamic a, dynamic b)
{
DynamicTests.MemberAccess(a & b);
DynamicTests.MemberAccess(a & 1);
DynamicTests.MemberAccess(a & null);
DynamicTests.MemberAccess(a | b);
DynamicTests.MemberAccess(a | 1);
DynamicTests.MemberAccess(a | null);
DynamicTests.MemberAccess(a ^ b);
DynamicTests.MemberAccess(a ^ 1);
DynamicTests.MemberAccess(a ^ null);
DynamicTests.MemberAccess(a << b);
DynamicTests.MemberAccess(a << 1);
DynamicTests.MemberAccess(a >> b);
DynamicTests.MemberAccess(a >> 1);
}

private static void RelationalOperators(dynamic a, dynamic b)
{
DynamicTests.MemberAccess(a == b);
Expand Down Expand Up @@ -369,6 +386,12 @@ private static void CompoundAssignment(dynamic a, dynamic b)
a.Setter2 -= b;
a.Setter2 *= b;
a.Setter2 /= b;
a.Setter2 %= b;
a.Setter2 &= b;
a.Setter2 |= b;
a.Setter2 ^= b;
a.Setter2 <<= b;
a.Setter2 >>= b;
field.Setter += 5;
field.Setter -= 5;
}
Expand All @@ -394,6 +417,7 @@ private static void UnaryOperators(dynamic a)
//++a;
DynamicTests.Casts(-a);
DynamicTests.Casts(+a);
DynamicTests.Casts(~a);
}

private static void Loops(dynamic list)
Expand Down
2 changes: 2 additions & 0 deletions ICSharpCode.Decompiler/CSharp/ExpressionBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4540,6 +4540,8 @@ protected internal override TranslatedExpression VisitDynamicUnaryOperatorInstru
return CreateUnaryOperator(UnaryOperatorType.Minus, isChecked: true);
case ExpressionType.UnaryPlus:
return CreateUnaryOperator(UnaryOperatorType.Plus, isChecked: inst.BinderFlags.HasFlag(CSharpBinderFlags.CheckedContext));
case ExpressionType.OnesComplement:
return CreateUnaryOperator(UnaryOperatorType.BitNot);
case ExpressionType.IsTrue:
var operand = TranslateDynamicArgument(inst.Operand, inst.OperandArgumentInfo);
Expression expr;
Expand Down
Loading