Add code review guidance and require Assisted-by on every agent commit - #4067
Merged
Merged
Conversation
siegfriedpammer
force-pushed
the
docs/code-review-guidelines
branch
3 times, most recently
from
August 28, 2026 11:23
f9fa690 to
278242d
Compare
siegfriedpammer
force-pushed
the
docs/code-review-guidelines
branch
3 times, most recently
from
August 28, 2026 16:43
3193ecf to
ab25ca4
Compare
An agent review of PR #4065 posted twelve comments and eight had to be withdrawn. Most were output of a decompdiff corpus sweep run against the PR branch, which measures the whole decompiler rather than the diff, and one called a cast a regression when it was the correct emission -- the old form compiled only because C# target-types the switch expression. The guide lives in .github/ rather than inline because most sessions never review anything and should not carry it, and because it is as useful to a human reviewer as to an agent. CLAUDE.md keeps only the two rules that have to hold before you have decided you are reviewing at all, plus the pointer. Assisted-by: Claude:claude-opus-5[1m]:Claude Code
The previous wording described what an AI-assisted commit looks like without saying the trailer is mandatory, which left it readable as a convention for substantial changes only. The marker is what lets a reader tell which work came from an agent, so it has to hold across all of it -- an exemption for trivial commits makes the absence of the trailer meaningless. The same reasoning closed a matching gap in how agents comment on PRs, where a single disclaimer on a review body left eleven inline comments unmarked. Assisted-by: Claude:claude-opus-5[1m]:Claude Code
siegfriedpammer
force-pushed
the
docs/code-review-guidelines
branch
from
August 28, 2026 16:51
ab25ca4 to
8971986
Compare
dgrunwald
approved these changes
Aug 28, 2026
christophwille
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two rules for agents working in this repo, both written after a concrete incident on #4065.
CLAUDE.mdonly, no code changes.Code review guidance (new section)
An agent review on #4065 posted twelve inline comments and eight had to be withdrawn. Two causes were worth writing down:
decompdiffcorpus sweep run against the PR branch. A sweep measures the whole decompiler, not the diff, so most of what it surfaces is pre-existing, unrelated, or a known limitation, and it does not belong in a review verbatim. Exploratory testing on a PR branch is still encouraged - it just gets triaged first, and what the diff did not cause becomes an issue instead.The section also sets the bar for what gets posted at all - output that does not compile, changes semantics, or crashes - with one deliberate exception for coverage gaps in the PR's own feature, since sweeps are good at finding those and the PR is the right moment to add the fixture.
Assisted-by on every agent-written commit
The existing wording described what an AI-assisted commit looks like without saying the trailer is required, which left it readable as a convention for substantial changes only. The marker is only informative if it is on all of the agent's work, so the exemption is removed. The same bullet extends it to PR and issue comments, where a single disclaimer on a review body had left eleven inline comments carrying no indication an agent wrote them.
Happy to drop either commit if the project would rather not carry this as guidance.
This pull request was opened by an AI agent (Claude) on Siegfried's behalf.