Wait for the resolved dependencies, not for the application to go idle - #4097
Merged
Merged
Conversation
Load_Dependencies_Resolves_References_And_Keeps_Them_In_The_List timed out on a loaded CI agent. The idle predicate it waited on also covers the dispatcher queue, and LoadDependenciesAsync ends with RefreshDecompiledView, so the test was waiting for a decompilation to finish - work whose duration is a property of the machine, not of the condition being asserted. Instrumenting the wait shows every assembly already loaded on the first poll while dispatcher jobs stay queued for seconds, so the loads were never the holdup. Waiting for the list to show the resolved dependencies drops the dependency on machine speed: under a deliberately shortened one-second deadline the previous wait failed every run and this one passed every run. Assisted-by: Claude:claude-opus-5:Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load_Dependencies_Resolves_References_And_Keeps_Them_In_The_Listtimed out on a loaded CI agent:Timed out after 60s waiting for the UI to become idle.Waiters.WaitForIdleAsyncalso requires the dispatcher queue to be empty, andLoadDependenciesAsyncends withRefreshDecompiledView()- so the test was waiting for a decompilation, whose duration is a property of the machine rather than of the condition being asserted. Instrumenting the wait shows every assembly loaded on the very first poll while dispatcher jobs stay queued for seconds; the assembly loads were never the holdup.Waiting for the list to show the resolved dependencies removes the dependency on machine speed. Under a deliberately shortened one-second deadline the previous wait failed 3/3 runs and this one passed 5/5; the fixture is green (51/51).
Prepared by an AI agent (Claude, claude-opus-5, via Claude Code) and reviewed by @siegfriedpammer.