Repository navigation
Conversation
This was referenced Jun 19, 2023
Closed
|
Hi, seems this pr has been a long time, I'm curious what is the status of this feature? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
This PR adds support for the
PostBuildtrait, which allows users to perform custom validation when the.build()method is called. The validation runs as the last step of thebuildmethod.An example:
When the user provides
#[builder(postbuild)], the macro won't implement a defaultPostBuildimpl. Instead, the user has to implement this trait manually. This allows user to implement custom validation logic.Note: Some test cases are commented out, as the initial draft of this feature breaks these test cases. Follow-up commits will fix those issues. As such, the PR is a draft. When the test cases are fixed and the code is polished, it is marked as "Ready to review".