Repository navigation
SHAREKIT 2.0 – ONE MAIN GLOBAL FORK #283
Description
Guys, I think it's time for ShareKit 2.0 managing only by community. So much good code was written, so much good features and fixes. That's really good!
But when I try to gather all these pieces from different forks .. it's just impossible.
We really need one common fork and mentors who will take care of pull requests.
Let's discuss?
Activity
troppoli commentedon Aug 3, 2011
Best I can tell I have all of the common changes in my fork, as well as fixes for leaks, allow configurable sharers list (so that you can subclass SHKsharers), callbacks for canceling out of sharers, added UI for flickr and removed a round trip to the server to set item attributes, allow you to nobble offline and other enhancements.
Off the top I've merged flickr integration, delegate config, new facebook and many more.
I would be open to having other admins on my fork, and could spare a little time to merge changes, but I don't want to be the only one.
-s
SlavaBushtruk commentedon Aug 3, 2011
This is really good! I see you're very active last time. Thank for the quick reply.
The main problem for ShareKit newbie is to select right fork. Then when any bug appears, e.g. Facebook doesn't share text right now, people try to fix and it's hard to find fixes and how to embed it in own changes code and so on. This becomes a mission impossible for newbies. So that's why I believe we need one fork and maybe ask @ideashower to delegate rights to new lead or so.
Honestly I am not very experienced in ShareKit, I just see my own problem and suggest that it's common.
Let's wait what other guys think.
I've sent a message @ideashower also.
mvdnbrk commentedon Aug 10, 2011
I agree with you that there should be one global fork.
It's getting pretty hard right now to get things up and running quickly.
There are a lot of enhancements fragmented over a lot of forks.
Apperently @ideashower doesn't have the time to maintain this fork.
If you guys need some help getting ShareKit to V2.0 I am willing to contribute to this project.
postmechanical commentedon Aug 18, 2011
This situation exemplifies the strength and weakness of open libs shared via GitHub. I suspect that ideashower is simply too busy to manage all the work that community is contributing and I suspect that would be the case for any individual or group who would take over. I would recommend that any beginner start with a fork of the jayway fork (https://github.com/jayway/ShareKit) and merge in other forks as needed.
ened commentedon Aug 23, 2011
Hey there- interested to see ShareKit in the hands of the community as well. A little busy these days with projects and usually use Github to keep the changes / additions somewhere at least. A central repository on Github would be great.
We could think about a simple upvote procedure by a core team of ShareKit contributors which decides what goes into the main GH-Project or not.
What is the next step to continue?
scompt commentedon Aug 24, 2011
I think this is a great idea. I sent message to @ideashower 5 months ago suggesting this and never got a response back.
I've created a GitHub organization called ShareKit and pushed the current contents of the repo there. I have no problem giving others admin rights to the org.
I think the next step should be deciding on a fork that will become the seed of ShareKit 2.0. It might also be useful to port the current issues from ideashower to the new org.
https://github.com/ShareKit/ShareKit
troppoli commentedon Aug 24, 2011
I've spent a fair amount of time merging all of the best changes into my fork. I've even fixed some long standing memory leaks and added enhancements to contributed elements.
https://github.com/troppoli/ShareKit
We are using this fork in our products and will do so for the foreseeable future.
-s
From: "scompt" reply@reply.github.com
Sent: Wednesday, August 24, 2011 3:22 AM
To: steve@eastcoastpixels.com
Subject: Re: [ShareKit] SHAREKIT 2.0 - ONE MAIN GLOBAL FORK (#283)
I think this is a great idea. I sent message to @ideashower 5 months ago suggesting this and never got a response back.
I've created a GitHub organization called ShareKit and pushed the current contents of the repo there. I have no problem giving others admin rights to the org.
I think the next step should be deciding on a fork that will become the seed of ShareKit 2.0. It might also be useful to port the current issues from ideashower to the new org.
https://github.com/ShareKit/ShareKit
Reply to this email directly or view it on GitHub:
#283 (comment)
coneybeare commentedon Aug 24, 2011
Whichever fork is used, I do recommend a "rebase" by putting it on the ShareKit/ShareKit tree. It will minimize confusion for users in the long run as to which branch is the "official" one, and can serve as the root for the 2.0 going forward. @troppoli @scompt
clozach commentedon Aug 31, 2011
I'd like to contribute, with the caveat that a) I still haven't grokked git and am therefore of limited use as an admin and b) I'm completely new to ShareKit.
Unless there's a good argument against either of these next steps...?
-C
clozach commentedon Aug 31, 2011
P.S. One thing that surprises me is that the ShareKit/ShareKit network graph is completely disconnected from the original. It seems like that might make it harder to pull useful commits from all of the existing project forks. (?)
troppoli commentedon Aug 31, 2011
There are a ton of forks that have become less and less compatible. I think that my fork as the bulk of the changes that people have been looking for and some fixes to fundamental issues.
coneybeare commentedon Aug 31, 2011
@troppoli, can you and @scompt work together to get on a more official repo with your code at ShareKit/ShareKit ?
scompt commentedon Aug 31, 2011
@clozach That's true. I pulled locally and then pushed up to github, which blew away the network graph. The one benefit that it has is that it doesn't say 'forked from ...', which might lend the repo some credibility as the canonical one. What are the others' opinion about this? Fork with network graph or pull/push without network graph?
Let's go with @troppoli 's repository in any case. That'll get us up and running with a good base from which we can start looking at the existing tickets to see which should be ported.
troppoli commentedon Sep 1, 2011
If you pull and push, you loose the history of where changes came from, what changes are in and the comments from the checkins. I think that they are too valuable to loose.
-s
From: "scompt" reply@reply.github.com
Sent: Wednesday, August 31, 2011 5:10 PM
To: steve@eastcoastpixels.com
Subject: Re: [ShareKit] SHAREKIT 2.0 - ONE MAIN GLOBAL FORK (#283)
@clozach That's true. I pulled locally and then pushed up to github, which blew away the network graph. The one benefit that it has is that it doesn't say 'forked from ...', which might lend the repo some credibility as the canonical one. What are the others' opinion about this? Fork with network graph or pull/push without network graph?
Let's go with @troppoli 's repository in any case. That'll get us up and running with a good base from which we can start looking at the existing tickets to see which should be ported.
Reply to this email directly or view it on GitHub:
#283 (comment)
coneybeare commentedon Sep 1, 2011
You can have both. http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/ This was the first google hit, I am sure there are other ways too.
@troppoli, it needs to be off of your personal fork to get any legs here as an "official" 2.0
26 remaining items
spiderguy84 commentedon Oct 15, 2011
I was able to take care of this problem with the help of someone in iphonedevsdk.com. One thing I am having issue with now is Facebook not sharing text. I use this code:
[CODE]
(IBAction)postGradesTapped:(id)sender {
self.textual = @"Test";
SHKItem *item = [SHKItem text:self.textual];
SHKActionSheet *actionSheet = [SHKActionSheet actionSheetForItem:item];
[actionSheet showInView:self.tabBarController.view];
}[/CODE]
Twitter and Email handle it fine, butFacebook just leaves dialog box empty, or will sometime give NSURLConnectionError -999 message.
spiderguy84 commentedon Oct 17, 2011
Ok, here is what I am having troubles with right now on the fork I am using. When you share a URL, the facebook window doesn't show the link that is being shared, although it does end up getting posted. I'm concerned that the user will think something is wrong when they don't see it, and cancel it. How can I set it up to show in the preview window of the app? Here is what the user sees:
http://www.316apps.com/usersees.png
Here is what gets posted:
http://www.316apps.com/getsposted.png
evripidis commentedon Nov 5, 2011
I've updated my files from the ShareKit web site with those in here.
Facebook has major issues. When i press FB share, it pops app the facebook app, and do nothing more.
KanybekMomukeyev commentedon Nov 9, 2011
evripidis, this problem occurs, when your application ID (which you registered in facebook) is incorrect.
sebrk commentedon Nov 9, 2011
I'm having difficulties following this (I'm not that into Git yet I guess). Will there be a ShareKit 2.0 in the coming days or weeks or even months?
vocaro commentedon Nov 10, 2011
@sebrk https://github.com/ShareKit/ShareKit
KanybekMomukeyev commentedon Nov 10, 2011
when i am sharing, in sharekit 2.0 LINK, everything is working ok,
i added to my project, everything is good, BUT when i try to share LINK with facebook,
nothing will happen. I've changed plist, used id that given in sharekit, nothing.... Please help
evripidis commentedon Nov 13, 2011
@KanybekMomukeyev The app ID is correct cause i can see the ID info into the FB app.
Here is exactly where i stuck. I am sharing a text with Link and nothing happens
Sjors commentedon Nov 29, 2011
@sebrk at the moment the development branch is the most recent:
https://github.com/ShareKit/ShareKit/tree/development
Here are the most up to date installation instructions (if I'm not mistaken):
https://github.com/ShareKit/ShareKit/wiki/Installing-sharekit
SlavaBushtruk commentedon Dec 9, 2011
My THANK TO YOU ALL CONTRIBUTORS post — http://www.alterplay.com/ios-dev-tips/2011/12/open-source-sharekit2.html
sateeshkumardamera commentedon Jul 20, 2012
I got the error like operation could not be completed, contents ={ "OAuthException"} contents ={ "(#100) action links must have string 'href' and 'text' attributes"}
Can any one help on this
xhzengAIB commentedon Sep 18, 2012
Please：
Why the sharekit added to my project is not working properly?Example: In SHKActionSheet.m files inside
id class;
for (NSString * sharerId in favoriteSharers)
{
NSLog (@ "% @", sharerId);
class = NSClassFromString (sharerId);
if ([class canShare])
{
[as addButtonWithTitle: [class sharerTitle]];
[as.sharers addObject: sharerId];
}
}
class is nil
How do I do?？？？
SohaibQazi commentedon Aug 1, 2013
Hi,
I have just downloaded ShareKit. I am trying to run ShareKit demo app.xproject file but it is showing me some errors like PocketAPI.h file not found. BufferSDK.h file not found. I don't know how to run the project of sharekit that i just downloaded. Can someone explain me how can i check it?
aelam commentedon Mar 17, 2015
Some vendors support SSO login. is it possible to add the feature in ?
ranamateen commentedon Apr 11, 2018
Getting this error while installing sharekit pods
