Conversation
maelle
commented
Jul 22, 2025
Contributor
|
I am still a stimulus newbie. Is the change in |
Contributor
Author
It should be, with the right command. |
Contributor
|
So we need to find the right command? 🕵♂️ |
Contributor
Author
|
Yep, but only if you agree with the change. |
Contributor
Author
|
krlmlr
reviewed
Aug 21, 2025
maelle
marked this pull request as ready for review
August 27, 2025 09:24
schochastics
approved these changes
Aug 27, 2025
Contributor
|
Running revdepchecks for this and #1981. |
Contributor
|
Too risky, seven new failures after this or the other PR. Let's wait. |
Contributor
Author
|
Actually these errors were already improved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd need some help with Stimulus, here I made the changes directly in aaa-auto.R to check the test results.