Add AirPlayEnable characteristic + service for SmartSpeakers#492
Open
wingrunr21 wants to merge 1 commit into
Open
Add AirPlayEnable characteristic + service for SmartSpeakers#492wingrunr21 wants to merge 1 commit into
wingrunr21 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds HomeKit resource definitions needed to represent smart speakers with AirPlay support.
Changes:
- Added a new
SmartSpeakerservice definition with media-state requirements. - Added an
AirPlayEnablecharacteristic definition (read/write + events) for toggling AirPlay.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyhap/resources/services.json | Introduces SmartSpeaker service metadata and characteristic requirements/optionals. |
| pyhap/resources/characteristics.json | Defines the AirPlayEnable characteristic used by the new service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+75
to
+85
| "AirPlayEnable": { | ||
| "Format": "uint8", | ||
| "Permissions": [ | ||
| "pr", | ||
| "pw", | ||
| "ev" | ||
| ], | ||
| "UUID": "0000025B-0000-1000-8000-0026BB765291", | ||
| "maxValue": 1, | ||
| "minValue": 0 | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
AirPlayEnablecharacteristicSmartSpeakerserviceThis is in prep for a PR against HA core to address the "group of switches" issues referenced in #275 and in home-assistant/core#157319
Should be consistent with the definitions in HAP-NodeJS:
AirPlayEnableSmartSpeaker