Repository navigation
fix(deps): fail cleanly on allocation failure instead of listing a dependency twice or crashing - #1180
Merged
Conversation
…pendency twice or crashing mt deps -r recorded each formula across three allocations with no rollback: a swallowed visited-set insert let a diamond or cycle list the same formula twice, and a later failure freed its name twice. Reserve all three containers before committing so an exhausted allocator surfaces as OutOfMemory with nothing leaked or double-freed.
… on allocation failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When memory ran out mid-walk,
mt deps -rcould list the same formula twice or crash. It now stops with an out-of-memory error and leaves nothing half-built behind.Related Issue
Notes for Reviewers