Skip to content

fix(tap): report an unreadable database instead of listing no taps - #1185

Merged
indaco merged 5 commits into
mainfrom
fix/tap-listing-refuses-unreadable-db
Oct 9, 2026
Merged

indaco merged 5 commits into
mainfrom
fix/tap-listing-refuses-unreadable-db

Conversation

@indaco

@indaco indaco commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Description

mt tap and mt --json tap no longer report a broken database as an empty tap list.

When malt.db exists but cannot be opened (unreadable, corrupt, or db/ not accessible), both commands now print "Cannot open the tap database" on stderr, leave stdout empty, and exit 1. Before, they printed "No taps registered" / [] and exited 0. Scripts and --json consumers could not tell a broken database from a real empty list.

Only an absent db/ still reads as an empty tap list. A db/ that exists without a malt.db and cannot be written now fails the same way, matching mt list.

Related Issue

  • None

Notes for Reviewers

  • The mode-000 checks skip when run as root.

@indaco
indaco merged commit 731c262 into main Oct 9, 2026
4 checks passed
@indaco
indaco deleted the fix/tap-listing-refuses-unreadable-db branch October 9, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant