Repository navigation
fix(tap): report an unreadable database instead of listing no taps - #1185
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mt tapandmt --json tapno longer report a broken database as an empty tap list.When
malt.dbexists but cannot be opened (unreadable, corrupt, ordb/not accessible), both commands now print "Cannot open the tap database" on stderr, leave stdout empty, and exit 1. Before, they printed "No taps registered" /[]and exited 0. Scripts and--jsonconsumers could not tell a broken database from a real empty list.Only an absent
db/still reads as an empty tap list. Adb/that exists without amalt.dband cannot be written now fails the same way, matchingmt list.Related Issue
Notes for Reviewers