Repository navigation
fix(services): show help for services subcommands instead of running them - #1188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mt services <sub> --helpran the subcommand instead of showing help, andservices list --helpcreated the database as a side effect. Help is now detected anywhere before--, matchingbundle.Unknown service names given to
start,stop,restart,logsandstatusnow printno such service: <name>instead of a rawerror: ServiceNotFound. Database errors still surface as themselves.Related Issue
Notes for Reviewers
bundleandrestorestart services throughservicesStart, which skips both the help scan and the new message.restoreprints its own warning, so a second one would duplicate it.supervisor.hasServicehad no production caller left, so it is removed.