Repository navigation
Advertise the ModelJars version Central actually serves (0.1.65 to 0.1.75) - #350
Merged
Merged
Conversation
modeljarsVersion sat at 0.1.65 while Central served 0.1.75, so five user-facing pages told readers
to depend on a library ten releases old: index.adoc, langchain4j.adoc, spring-ai.adoc,
spring-boot.adoc and using-models.adoc all interpolate {modeljars-version}. 0.1.65 predates the
ONNX intake, the speech loader, and the GLiNER and mellum catalog entries, so a reader following
the documentation gets a runtime that cannot load several models the catalog advertises.
modeljarsVersion is documentation only -- no module depends on ModelJars and no lockfile pins it,
which is how it drifted without a build failing.
verifyDocumentation already gates this and did its job: bumping the property alone failed the task,
which named docs/landing/index.html, then named docs/landing/assets/js/landing.js on the next run.
The latter is the trap its own comment records from the ModelJars side -- fixing the page while the
script that generates the snippet boxes keeps emitting the old coordinate. landing.js carried the
version eight times, once per build tool.
verifyDocumentation, verifyReleaseMetadata and complianceCheck all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five user-facing pages advertised a ten-release-old ModelJars
modeljarsVersionwas0.1.65; Central serves 0.1.75. These pages interpolate{modeljars-version}and so all told readers to depend on 0.1.65:docs/content/modules/ROOT/pages/→index.adoc,langchain4j.adoc,spring-ai.adoc,spring-boot.adoc,using-models.adoc0.1.65 predates the ONNX intake, the speech loader, and the GLiNER and mellum catalog entries. A
reader following the docs gets a runtime that cannot load several models the catalog advertises.
It drifted silently because
modeljarsVersionis documentation-only — no module depends onModelJars and no lockfile pins it — so no build ever resolved it.
verifyDocumentationalready gates this, and it workedI bumped the property alone; the task failed and named the next offender, twice:
then
The second one is exactly the trap that task's own comment records from the ModelJars site — fixing
the visible page while the script generating the snippet boxes keeps emitting the stale coordinate.
landing.jscarried the version eight times, once per build tool (Gradle Kotlin, Gradle Groovy,Maven, SBT). My own
grephad missed it by not including.js; the gate caught what I didn't.No machinery is added here — it already exists and is thorough. Only the value was stale.
One gap left, deliberately not closed here
verifyDocumentationchecks internal consistency against the declared property, not against MavenCentral, so the property itself can still drift from what is published. ModelJars solved this with
tools/verify-site-version.mjs, which takes Central's<release>as authority on the grounds that"a source tag does not prove a visitor can resolve the dependency shown on the page". The same
argument applies here. That needs a network check in CI rather than in
build, so it is a separatechange and not smuggled into this one.
Gates
verifyDocumentation,verifyReleaseMetadata,complianceCheck— BUILD SUCCESSFUL.