Skip to content

[TD-09] 13 #[allow(dead_code)] cluster in web/state and web tests #327

Closed

Description

@intendednull

Audit finding from #300 (commit 679f9fe)

Severity: low
Category: tech debt
File: crates/web/tests/browser.rs (4), crates/web/src/state.rs (4), crates/web/src/{palette_recents.rs, components/mobile_shell.rs, app.rs} (1 each), crates/client/src/storage.rs:1, crates/actor/src/fsm.rs:1
Obvious fix: yes

Description

13 #[allow(dead_code)] annotations. Half are in the web crate. These are typically a leading indicator of code that was added speculatively or left after a refactor.

Impact / Threat

Readability — masks genuinely-dead code from the compiler.

Suggested fix

Remove the annotation, let the compiler flag the symbol, then either delete or mark pub(crate) if a downstream consumer is planned.

Verify

rg "#\[allow\(dead_code\)\]" --type rust crates/ -c | sort -t: -k2 -nr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions