Skip to content

[Feature] Non-Conformance - #12682

Draft
SchrodingersGat wants to merge 29 commits into
inventree:masterfrom
SchrodingersGat:ncr
Draft

[Feature] Non-Conformance#12682
SchrodingersGat wants to merge 29 commits into
inventree:masterfrom
SchrodingersGat:ncr

Conversation

@SchrodingersGat

@SchrodingersGat SchrodingersGat commented Aug 22, 2026

Copy link
Copy Markdown
Member

@SchrodingersGat SchrodingersGat added this to the 1.6.0 milestone Aug 22, 2026
@SchrodingersGat SchrodingersGat added api Relates to the API feature migration Data or schema migrations User Interface Related to the frontend / User Interface full-run Always do a full QC CI run labels Aug 22, 2026
@netlify

netlify Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for inventree-web-pui-preview failed.

Name Link
🔨 Latest commit 0ac3664
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6adc6634ef068c4644b1ae50

@SchrodingersGat
SchrodingersGat marked this pull request as draft August 22, 2026 04:01
@codecov

codecov Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 43.98074% with 349 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.89%. Comparing base (cdb3b1e) to head (0ac3664).

❌ Your project check has failed because the head coverage (91.85%) is below the target coverage (92.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12682      +/-   ##
==========================================
- Coverage   87.20%   86.89%   -0.32%     
==========================================
  Files        1534     1537       +3     
  Lines      106558   107176     +618     
  Branches    11964    11965       +1     
==========================================
+ Hits        92927    93128     +201     
- Misses      13565    13982     +417     
  Partials       66       66
Flag Coverage Δ
migrations-mysql 34.11% <43.98%> (+0.01%) ⬆️
migrations-postgresql 34.13% <43.98%> (+0.01%) ⬆️
migrations-sqlite 34.12% <43.98%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 91.85% <43.98%> (-0.63%) ⬇️
Backend General 94.50% <ø> (ø)
Frontend 79.35% <ø> (-0.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matmair

matmair commented Aug 22, 2026

Copy link
Copy Markdown
Member

Very interesting for bettering MES area of the platform.
As this is an advanced concept that might not be enabled on most sites, I think this would be a great candidate for a built-in plugin as there is not much interaction with the rest of the platform. This could be used to detect and discuss implementation patterns that are non ergonomic (the way FSM transitions are exposed through APIs for example).

matmair
matmair reviewed Aug 23, 2026
View reviewed changes
Comment thread src/backend/InvenTree/build/api.py Outdated
Comment on lines +1133 to +1147
class NCRMixin:
"""Mixin class for NonConformance (NCR) API endpoints."""

queryset = NonConformance.objects.all()
serializer_class = build.serializers.NonConformanceSerializer


class NCRListOutputOptions(OutputConfiguration):
"""Output options for the NCRList endpoint."""

OPTIONS = [InvenTreeOutputOption('part_detail', default=True)]


class NCRList(NCRMixin, OutputOptionsMixin, ListCreateAPI):
"""API endpoint for accessing a list of NonConformance (NCR) objects.

@matmair matmair Aug 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementing this via a viewset might be more efficient (see #12317)

@matmair matmair Aug 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also #12693

@SchrodingersGat SchrodingersGat modified the milestones: 1.6.0, 1.7.0 Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matmair matmair matmair left review comments

Assignees

No one assigned

Labels

api Relates to the API feature full-run Always do a full QC CI run migration Data or schema migrations User Interface Related to the frontend / User Interface

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

[Feature] Build Order Non Conformance

2 participants

@SchrodingersGat @matmair