Type check scripts against the SDK reference assemblies - #333
Merged
Merged
Conversation
GetProjectOptionsFromScript defaults to assumeDotNetFramework = true, so a .fsx passed with --script was resolved against the .NET Framework reference assemblies. FSharp.Core then failed to load and everything coming from it (printfn, string, int, ...) was undefined. Those constructs end up as error recovery nodes in the typed tree, which analyzers cannot match on, so a --script run silently reported nothing for most of the script. Also warn when a project or script does not type check, so a run that can only cover part of the code no longer looks clean. Fixes ionide#332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetProjectOptionsFromScript defaults to assumeDotNetFramework = true, so a .fsx passed with --script was resolved against the .NET Framework reference assemblies. FSharp.Core then failed to load and everything coming from it (printfn, string, int, ...) was undefined. Those constructs end up as error recovery nodes in the typed tree, which analyzers cannot match on, so a --script run silently reported nothing for most of the script.
Also warn when a project or script does not type check, so a run that can only cover part of the code no longer looks clean.
Fixes #332