Reference the fsi settings assembly when loading a script - #335
Merged
Merged
Conversation
A script may use the `fsi` object (fsi.CommandLineArgs, fsi.EventLoop, ...) without saying anything, because `dotnet fsi` references FSharp.Compiler.Interactive.Settings.dll implicitly. FCS looks for that assembly next to its own binaries, which for a dotnet tool are the tool's own files, so the reference silently dropped and every use of `fsi` failed to type check. Error recovery then took the surrounding expressions with it, leaving analyzers nothing to match on. Pass `-r:` for the copy that ships in the FSharp folder of the SDK that toolsPath points into, so scripts resolve `fsi` against the same SDK that MSBuild loads projects with. Fixes ionide#334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script may use the
fsiobject (fsi.CommandLineArgs, fsi.EventLoop, ...)without saying anything, because
dotnet fsireferencesFSharp.Compiler.Interactive.Settings.dll implicitly. FCS looks for that
assembly next to its own binaries, which for a dotnet tool are the tool's
own files, so the reference silently dropped and every use of
fsifailedto type check. Error recovery then took the surrounding expressions with
it, leaving analyzers nothing to match on.
Pass
-r:for the copy that ships in the FSharp folder of the SDK thattoolsPath points into, so scripts resolve
fsiagainst the same SDK thatMSBuild loads projects with.
Fixes #334