Skip to content

Remove duplicate 'Reference' active pattern - #1538

Closed
Numpsy wants to merge 2 commits into
ionide:mainfrom
Numpsy:dedup_1
Closed

Numpsy wants to merge 2 commits into
ionide:mainfrom
Numpsy:dedup_1

Conversation

@Numpsy

@Numpsy Numpsy commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Not sure what the history is here, but when I try to do a local build I get

  FsAutoComplete.Core net8.0 failed with 1 error(s) (3.0s)
    G:\Dev\FsAutoComplete\src\FsAutoComplete.Core\CompilerServiceInterface.fs(229,8): error FS1182: The value '(|Reference|_|)' is unused

but there appears to be two copies of the same function - this one and one on line 199 - which looks wrong anyway?

@Numpsy

Numpsy commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Maybe down to dotnet/fsharp#19805 in the compiler. causing the 10.0.400 version to pick this up where the older ones didn't

@Numpsy

Numpsy commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

Same with this other CI error I suppose

/home/runner/work/FsAutoComplete/FsAutoComplete/src/FsAutoComplete/LspServers/FSharpLspClient.fs(196,7): error FS1182: The value 'strEquals' is unused [/home/runner/work/FsAutoComplete/FsAutoComplete/src/FsAutoComplete/FsAutoComplete.fsproj::TargetFramework=net10.0]

@Numpsy

Numpsy commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

I guess the .NET 8 failures are down to the issues from #1537?

@TheAngryByrd

Copy link
Copy Markdown
Member

@Numpsy
Numpsy deleted the dedup_1 branch August 29, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants