Repository navigation
Event Handling has to be updated after breaking change in controller-runtime #1489
Description
Describe the bug
Release v0.4.0 updated controller-runtime to v0.23.x which brings a breaking change:
- Events: Migration to the new events API by @clebs in ⚠️ Migration to the new events API kubernetes-sigs/controller-runtime#3262
- Using the new GetEventRecorderFor requires updating your rbac for events to use the events.k8s.io apiGroup rather than the `` (core) apiGroup
Currently we see errors like this from controllers in the machine poollet:
1 event_broadcaster.go:270] "Server rejected event (will not retry!)" err="events.events.k8s.io \"webapp.18bba95a36d521da\" is forbidden: User \"system:serviceaccount:libvirt-provider:libvirt-provider-controller-manager\" cannot patch resource \"events\" in API group \"events.k8s.io\" in the namespace \"default\"" event="&Event{...}"
The events.k8s.io apiGroup also make the action field required. Events where the field is not set are rejected:
E0629 11:14:07.923183 1 event_broadcaster.go:270] "Server rejected event (will not retry!)" err="Event \"webapp.18bba95a36d521da\" is invalid: action: Required value" event="&Event{...}"
This part requires changes in the code.
To Reproduce
Use ironcore-in-a-box and create a machine. Check the logs of the libvirt-provider pod.
Expected behavior
No such error logs.
ToDos
- RBAC changes for controllers in ironcore and its manifests -> Grant RBAC for events in events.k8s.io API group #1490
- config file in libvirt-provider (service account is also used by machinepoollet)
- Ensure
actionfield is set for all events- libvirt-provider
- ceph-provider
Activity
[-]RBAC for Events have to be updated after breaking change in controller-runtime[/-][+]Event Handling has to be updated after breaking change in controller-runtime[/+]Fix empty action field on IRI-mapped events
lukasfrank commentedon Jul 3, 2026
ceph-provideralso needs to be fixed, ifprovider-utilsintroduces an interface changeFix empty action field on IRI-mapped events (#1500)
Add action field to Eventf calls and propagate it to IRI events (#892)