Integer sizes - ID fields and page numbers need to support int64 values #4

Activity

1. MortenRei commented on Feb 10, 2018

   

   MortenRei

   on Feb 10, 2018

   ContributorAuthor

   More actions

   IS there any chance on getting permissions on the repo to create a new branch and commit the fixes I've done?

   Per now, I've done the following to all files;

   Improvements;

   • Changed relevant int values to int64 to handle larger IDs
   • Updated commands with missing positional arguments
   • Removed all double-quoted strings and replaced them with the -f operator and single quoted strings

   Other:

   • Replaced write-host with write-verbose. Write-should never be used, as it clutters the outstream
   • Formatted all files to improve readability.
2. CalebAlbers commented on Feb 10, 2018

   

   CalebAlbers

   on Feb 10, 2018

   Contributor

   More actions

   Hey MortenRei,

   Thanks for the feedback! You made good points all around.

   If you would be willing to share your changes, please fork the repo and make a merge request with the updated code. None of the changes you mentioned should break anything, but I try to make it a habit of testing each request before merging into Master.

   Thanks again!
3. CalebAlbers

   closed this as completedon Feb 24, 2018
4. adrianwells

   added

   enhancement

   on Jan 14, 2019
5. chrisjantzen

   added a commit that references this issue on Sep 2, 2020

   Merge pull request itglue#4 from intellicomp/Related-Items

   ...

   22c7311