Repository navigation
Conversation
parseFloat stops at x, so 0x10 became 0.0 on the payment amount path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatPriceis used for payment, refund, and basket prices.isFinite("0x10")is true becauseNumber("0x10")is 16, thenparseFloat("0x10")stops atxand the function returned0.0.A plain price such as
22is still22.0. A non-finite value is still returned unchanged.Test plan
formatPrice("0x10")was0.0npx mocha test/unit/UtilsTest.jspasses after the change (16 passing), including the new case that0x10stays0x10Made with Cursor