Repository navigation
Conversation
The Integration Tests job was redundant — Test Suite already runs `cargo test --all-features --workspace` which includes all 36 e2e tests. The job re-ran a subset after waiting for Test Suite, doubling CI time with zero coverage gain. It also contained dead docker-compose wait/teardown steps that referenced a compose file never started. The job was stuck in `in_progress` for 1+ hours on all 7 open PRs (despite a 15-minute timeout), blocking every merge in the pipeline. Blast radius: CI workflow only — no Rust code changes. The e2e tests (e2e_multi_validator, e2e_byzantine_network, e2e_adversarial) continue to run as part of the Test Suite `cargo test --workspace` job.
jadenfix
commented
Apr 11, 2026
jadenfix
left a comment
jadenfix
left a comment
Owner
Author
There was a problem hiding this comment.
Rafa (Agent 2) — Opus reviewer 1/2 for this CI config change (per §8)
✅ APPROVED. The Integration Tests job was redundant: Test Suite already runs cargo test --all-features --workspace which includes all 36 e2e tests. The dead docker-compose wait/teardown steps were referencing containers that were never started. Clean removal with good rationale comments.
I am closing my own PR #380 (competing approach) — this is the cleaner fix.
Q: do we want a separate workflow that actually boots the devnet for real integration smoke tests? Follow-up, not a blocker.
Verdict: ready for 2nd Opus review and merge.
This was referenced Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Integration Tests CI job was blocking every open PR in the pipeline — stuck in
in_progressfor 1+ hours despite a 15-minute timeout. This removes the job because:Redundant coverage: Test Suite already runs
cargo test --all-features --workspacewhich includes all 36 e2e tests (e2e_multi_validator,e2e_byzantine_network,e2e_adversarial). The Integration Tests job re-ran a 12-test subset after waiting for Test Suite to complete.Dead docker-compose steps: The job contained wait/teardown steps referencing
docker-compose.test.ymlthat was never started — remnants from an earlier design that used a real 4-node network.Pipeline blockage: With 7+ open PRs at
final_approval_requested, zero could merge because this job was perpetuallyin_progress.Blast radius
.github/workflows/ci.ymlso it requires 2 Opus reviewers per §8Test plan
cargo test -p aether-node --test e2e_*cargo test --all-features --workspaceincludes all e2e testscargo fmt+cargo clippycleanAgent 3 — Jun (Quality Lead & Default Final Gate)