Repository navigation
fix(sdk): route rpc_call and getHealth through AbortSignal timeout - #392
Merged
Merged
Conversation
rpcCall() and getHealth() would hang indefinitely when the node was unresponsive. Wire AbortSignal.timeout(requestTimeoutMs) into both fetch calls, add requestTimeoutMs to ClientConfig (default 30 s), and add four regression tests that verify the signal is forwarded and fires correctly. Mirrors the same fix applied to the Python SDK in #387. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jadenfix
pushed a commit
that referenced
this pull request
Apr 11, 2026
… job The integration job comment said Docker compose was removed, but the steps still contained a 30-second docker compose health-check loop, a failure log collector, and a cleanup step — all referencing docker-compose.test.yml. Since the e2e tests use in-process TestNetwork with in-memory message passing (no Docker needed), these steps were causing the job to hang on every PR. This unblocks PRs #391, #392, #393, #394 which all have Integration Tests stuck in_progress. Blast radius: CI workflow only. No production code changed. The Docker Build job still validates the container image compiles. The e2e tests themselves are unchanged — only the stale Docker wait/ cleanup wrapper was removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requestTimeoutMsto TS SDKClientConfig(default 30s)AbortSignal.timeout()into bothrpcRequestandgetHealthfetch callsTest plan
🤖 Agent 4 — Sam (Peer Reviewer / Generalist)
PR created by Rafa (Agent 2) on Sam's behalf while GitHub API was partially available