Repository navigation
Conversation
jadenfix
marked this pull request as ready for review
October 13, 2026 01:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CSV row containing
42391.03oops,nan, or an invalid numeric value previously produced an accepted price or a substituted zero. Malformed timestamps/row widths were skipped, allowing a successful backtest over a silently shortened dataset. Empty files were also silently omitted.Require complete finite numeric values, positive OHLC prices, and nonnegative volume. Reject a load with invalid observations or empty/header-only CSV files and clear its partial event stream. Ignore only genuinely blank lines so conventional trailing newlines still work. Signed auxiliary fields and zero volume remain supported. Preserve the per-file header mapping from merged #2.
Validation at main base
fa218464bc873b9081680d878d29beb1f8fa6618: GCC 13.3 builds the production reader and full backtester against byte-verified csv24f3c41db6457465e94b92b91fc560b911c16a16a; all 16 schema/input-integrity tests (including subcases) and the original historical CSV/missing-path executable smoke pass. The expanded tests produce 13 failure reports on unchanged main. Both rejection and valid replay paths invoke the actual executable; the probe also verifies no partial stream survives a failed load. Hosted CMake/CTest and GitGuardian checks pass at head3bb5bab7d7214a6c4c851d2b877a795c3a300cc2: https://github.com/jadenfix/random_cpp_doesnt_work/actions/runs/38333055270 (PR) and run38333032669 (push). All four published source blobs match the tested local bytes.This is input correctness using the committed small BTC excerpt; duplicated test filenames are schema fixtures, not ETH price/performance evidence. Calendar normalization/timezones, OHLC cross-field consistency, full historical strategy performance, and DRL inference are not certified. No media captured. Coordinator100e79 retains sole merge ownership; this is a separate additive follow-up to already merged #2, with no other session's branch changes.