Repository navigation
fix: stabilize posterior updates at extreme Bayes factors - #70
Merged
Merged
Conversation
Owner
Author
Independent exact-head review — CLEARReviewed exact head
This is narrowly a numerical-stability/input-validation repair. It does not validate likelihood models or provide evidence for any simulation hypothesis. No blocker found. Ready for designated sole-merger review; not merged here. |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inf / inf1.0and reject NaN Bayes factorsReproduced boundary
On base
4e88e771e33bddca3ce3e718da7ed4b531c987d2:At fix commit
ec2ad8caeeabbba28252b799cf5ca8101881b641, the same calls return1.0,1.0, and(..., 1.0); a NaN Bayes factor raisesValueError.Verification
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=src python -m pytest -p no:cacheprovider: 426 passed in 1337.38spython -m compileall -q src scripts: 109 files compiledpython -m simtheory.experiments: exit 0, 151 output linesSource-pinned media
The receipt compares base
4e88e771e33bddca3ce3e718da7ed4b531c987d2with fixec2ad8caeeabbba28252b799cf5ca8101881b641by loadinginference.pydirectly from both Git revisions. It also records the focused test command and verified paths.docs/media/posterior-boundary-demo.gif— SHA-2564caa0bacdec47f69132ff9c36c1325cceebc47ce07f33e2007f031f58115bfc9docs/media/posterior-boundary-demo.mp4— SHA-2561fa27eaf90e27551f220519aa56f40be249b9caff99eb13a435d3a40905f4224docs/media/posterior-boundary-demo-receipt.json— SHA-2565349d9d86e9b6b71e263fb6904e469cc046bebc5fe403b7fe6b34eddda98ee51Scientific boundary
This is a numerical-stability and input-validation fix. It does not validate any supplied likelihood model, change identifiability assumptions, or provide evidence for any simulation hypothesis.