Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Comment on lines
+318
to
+323
| return (options.presets ?? DEFAULT_SNOOZE_PRESETS) | ||
| .flatMap((setting) => resolveSnoozePreset(setting, now, options.formatTime) ?? []) | ||
| .filter((preset) => { | ||
| if (seen.has(wakeMinute(preset))) return false; | ||
| seen.add(wakeMinute(preset)); | ||
| return true; |
There was a problem hiding this comment.
🔍 Default ordering needs approval check
With unedited presets, resolveSnoozePresets now follows the built-in array even when wake times differ. The contribution rules require prior approval for changed product defaults; the PR description does not link it.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Snooze options in Settings → Threads are always sorted soonest first, and every snooze menu uses that same order. To get a preferred option to the top, you had to delete every option above it and add them back. There was no way to move one.
Change
packages/client-runtime'sresolveSnoozePresets, so the web/desktop sidebar, the thread action menu, and mobile all follow the saved order. Mobile has no snooze editor, so nothing else changes there.Scope and approval
This configures an existing capability: the customizable snooze options added in pingdotgg#26208. It only controls the order of options a user has already chosen. No new snooze kinds, storage fields, or schema changes.
snoozePresetswas already an ordered array.PR #26208 deliberately chose automatic ordering ("Menus always list options soonest first, so there is no reordering to manage"), and #26427 made the editor match. This PR reverses that choice, so upstream would need maintainer sign-off. Existing users with saved presets will see their menu in saved order, which is usually the sorted order the editor already wrote.
Verification
vp test run packages/client-runtime/src/state/threadSnoozed.test.ts: 36 passed. The tworesolveSnoozePresetscases that asserted soonest-first ordering now assert settings order, and both failed before the change.vp run check:changed: format, lint, knip, typecheck (7 packages), tests, and React compiler all pass.Before: the editor always sorts rows soonest first, with no reorder control (screenshot from the current app):
After: rows have drag handles, and the description says menus follow this order:
After: the thread's Snooze menu follows the saved order:
Reorder, then open the menu:
Not verified: dragging with a real mouse in the recording. Browser automation could not produce the intermediate pointer moves dnd-kit needs, so the recording shows the keyboard reorder instead. The mouse path uses the same
PointerSensorsetup as the existing route list inEnvironmentRoutesList. Mobile was not run, because it only consumes the shared ordering function that the tests above cover.Claude Opus 5.5 via Claude Code in T3 Code.