Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken#33
Closed
jakebailey wants to merge 1 commit into
Closed
Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken#33jakebailey wants to merge 1 commit into
jakebailey wants to merge 1 commit into
Conversation
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 17:10
79f21b3 to
ce2b59b
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 10, 2022 17:10
c71f8ba to
b88df81
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 21:05
ce2b59b to
b124ac1
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
2 times, most recently
from
October 10, 2022 22:54
5c81d1a to
3d4c9f0
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 23:14
435ba70 to
49047e7
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 10, 2022 23:14
3d4c9f0 to
2d7af0f
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 10, 2022 23:31
49047e7 to
a96025d
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 10, 2022 23:31
2d7af0f to
41e57d6
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 11, 2022 23:15
a96025d to
26681a1
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 11, 2022 23:15
41e57d6 to
95bb6e2
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 11, 2022 23:31
26681a1 to
535e94d
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 11, 2022 23:31
95bb6e2 to
f782b2c
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 12, 2022 22:48
535e94d to
b0f7ebf
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 12, 2022 22:48
f782b2c to
e5fd341
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 19:36
b0f7ebf to
9a8a98e
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 14, 2022 19:36
e5fd341 to
26ba28d
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 21:20
9a8a98e to
c08a758
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 14, 2022 21:20
26ba28d to
9c72255
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 22:28
c08a758 to
3e53449
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 14, 2022 22:28
9c72255 to
229d522
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 14, 2022 23:34
3e53449 to
725b6c7
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 14, 2022 23:35
229d522 to
9e92519
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 20, 2022 00:50
725b6c7 to
dc69cb3
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 20, 2022 00:50
9e92519 to
c2e8900
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 20, 2022 01:25
dc69cb3 to
bb59776
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 23, 2022 00:11
55df9a0 to
83940ec
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 04:38
c9712e2 to
5334e71
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 24, 2022 04:38
83940ec to
a8d521e
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 18:10
5334e71 to
cb2ccfd
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 24, 2022 18:10
a8d521e to
b0bf572
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 20:33
cb2ccfd to
f9f8e9e
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 24, 2022 20:33
b0bf572 to
e1ee5ae
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 24, 2022 23:15
f9f8e9e to
a7d2107
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 24, 2022 23:16
e1ee5ae to
384ab90
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 25, 2022 02:25
a7d2107 to
1f616d1
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 25, 2022 02:25
384ab90 to
9f324c5
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 27, 2022 17:46
1f616d1 to
393d0de
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 27, 2022 17:47
9f324c5 to
67d85a4
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 28, 2022 02:28
393d0de to
540a735
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 28, 2022 02:29
67d85a4 to
7360152
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
October 31, 2022 21:39
540a735 to
abb36fd
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
October 31, 2022 21:40
7360152 to
6aa7f3e
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
November 2, 2022 00:50
abb36fd to
9f30548
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
November 2, 2022 00:50
6aa7f3e to
47028cb
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
November 2, 2022 17:01
9f30548 to
935be03
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
November 2, 2022 17:02
47028cb to
c2c6386
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
November 2, 2022 19:52
935be03 to
51893a6
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
November 2, 2022 19:52
c2c6386 to
a524243
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
November 6, 2022 21:53
51893a6 to
7e5b706
Compare
jakebailey
force-pushed
the
transform-stack-commit-31
branch
from
November 6, 2022 21:53
a524243 to
08fe163
Compare
jakebailey
force-pushed
the
transform-stack-commit-30
branch
from
November 6, 2022 21:59
7e5b706 to
3fa05c2
Compare
…o be tree shaken This debug code was added quite a while ago, constructed such that we wouldn't have to ship this code to our users. However, this is the sole place in the compiler project where the ts namespace "escapes" the bundle. By moving this debug code into the compiler itself, we no longer have any references to the ts namespace itself for our bundles that don't export anything (tsc, typingsInstaller). This lets bundlers tree shake the compiler, reducing the size of our output by _5.7 MB_ (a ridiculous improvement for _adding_ code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This debug code was added quite a while ago, constructed such that we
wouldn't have to ship this code to our users.
However, this is the sole place in the compiler project where the ts
namespace "escapes" the bundle. By moving this debug code into the
compiler itself, we no longer have any references to the ts namespace
itself for our bundles that don't export anything (tsc,
typingsInstaller). This lets bundlers tree shake the compiler, reducing
the size of our output by 5.7 MB (a ridiculous improvement for
adding code).
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: