Skip to content

fixed entities path bug of the connection in the dev mode - #47

Merged
javieraviles merged 2 commits into
javieraviles:developfrom
mberneti:master
Sep 12, 2019
Merged

javieraviles merged 2 commits into
javieraviles:developfrom
mberneti:master

Conversation

@mberneti

Copy link
Copy Markdown
Contributor

related to this issue #37

@javieraviles

Copy link
Copy Markdown
Owner

I really like this idea, is simple but never bothered to automate it... was causing some pain though, so I'm glad you made it.

One point here is; why the Function part in line 11? I might be overlooking it but can't understand why is there? I'm not proficient in Typescript either :)

Second point: will move the base branch for the PR to develop

Third and last one: as you already created a const to establish whether is dev mode or note, should we use it for debugLogging and dbsslconn?

Thanks again!

@javieraviles
javieraviles changed the base branch from master to develop September 12, 2019 18:26
@javieraviles

Copy link
Copy Markdown
Owner

I added some modification and now works as expected, looks good now :)

@javieraviles
javieraviles merged commit 3c62247 into javieraviles:develop Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants