[Colocated Python] Fix a deadlock during garbage collection under free threading#38144
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_924981686
branch
5 times, most recently
from
51b1575 to
99738b5
Compare
…e threading Python garbage collection may get stuck indefinitely when colocated Python objects are used in Python free threading. This is because when `_ConsumableRef.__call__` holds a mutex lock, garbage collection can happen and invoke `MethodCallerAtBackend.__del__` for the `MethodCallerAtBackend` that used to own that `_ConsumableRef` object. This `MethodCallerAtBackend.__del__` in turn would call the same `_ConsumableRef.__call__` and blocks on the same mutex. This problem can be mitigated by making the mutex reentrant, and this does not affect the logic of `_ConsumableRef.__call__`. PiperOrigin-RevId: 925717965
copybara-service
Bot
force-pushed
the
test_924981686
branch
from
99738b5 to
226d04d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Colocated Python] Fix a deadlock during garbage collection under free threading
Python garbage collection may get stuck indefinitely when colocated Python objects are used in Python free threading. This is because when
_ConsumableRef.__call__holds a mutex lock, garbage collection can happen and invokeMethodCallerAtBackend.__del__for theMethodCallerAtBackendthat used to own that_ConsumableRefobject. ThisMethodCallerAtBackend.__del__in turn would call the same_ConsumableRef.__call__and blocks on the same mutex. This problem can be mitigated by making the mutex reentrant, and this does not affect the logic of_ConsumableRef.__call__.