Skip to content

scratch: draft→ready dedupe check (do not merge) - #10

Closed
jayleaton wants to merge 4 commits into
mainfrom
scratch/ci-race2
Closed

jayleaton wants to merge 4 commits into
mainfrom
scratch/ci-race2

Conversation

@jayleaton

Copy link
Copy Markdown
Owner

Scratch; will be closed.

jayleaton and others added 4 commits October 22, 2026 14:17
A force-push to a draft PR followed by "ready for review" a second later
started two runs in one concurrency group; when the draft run arrived
last it cancelled the real run, and its skipped ci-ok then counted as
the passing required check for the head SHA.

Draft and real runs now use separate concurrency groups, only PR runs
cancel superseded runs, and jobs in draft runs are renamed
"<job> (draft, not run)" so they never report as ci-ok.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…revious head

When a push and "ready for review" land together, GitHub can attach the
ready_for_review run to the old head, leaving the new SHA with only the
skipped draft run and no ci-ok. A small draft job now checks the live
PR state: if the PR is ready and no other CI run covers this SHA, the
run does the real checks. ci-ok always runs and reports as
"ci (draft, not run)" in runs that stayed drafts, which also replaces
the job renames whose expressions showed raw on skipped jobs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opening a draft PR and marking it ready seconds later let the draft run
check before GitHub had created the ready run, so both ran the full
checks. Waiting 15 s (only when the PR is already ready) avoids the
duplicate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jayleaton
jayleaton marked this pull request as ready for review October 22, 2026 07:43
@jayleaton jayleaton closed this Oct 22, 2026
@jayleaton
jayleaton deleted the scratch/ci-race2 branch October 22, 2026 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant