Repository navigation
Conversation
jayleaton
marked this pull request as ready for review
October 22, 2026 09:06
This was referenced Oct 22, 2026
jayleaton
added a commit
that referenced
this pull request
Oct 23, 2026
…s web + admin Ported from auto-visuals #31 (why: #26, #29). CI never built the images or booted the binaries, so an image that cannot start, or a production config that refuses to boot without an optional integration, reached a deploy first. scripts/release-smoke.sh, in the single ci job (and make release-smoke): 1. builds every binary that has a Dockerfile with that Dockerfile's own build-stage ENV and RUN line (scripts/dockerfile-builds.sh reads them; nothing copies the flags), and fails if one is dynamically linked; 2. runs the binaries' own migrate on fresh databases; 3. boots web and admin with APP_ENV=production and only the config production requires, until /healthz answers 200. It runs only when a build input changed: scripts/affected.sh outputs smoke=true for a full run, a changed Dockerfile, or an affected package that a Dockerfile builds (test files alone do not count). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayleaton
added a commit
that referenced
this pull request
Oct 23, 2026
…s web + admin (#115) * ci: release smoke builds every Dockerfile's binary, migrates and boots web + admin Ported from auto-visuals #31 (why: #26, #29). CI never built the images or booted the binaries, so an image that cannot start, or a production config that refuses to boot without an optional integration, reached a deploy first. scripts/release-smoke.sh, in the single ci job (and make release-smoke): 1. builds every binary that has a Dockerfile with that Dockerfile's own build-stage ENV and RUN line (scripts/dockerfile-builds.sh reads them; nothing copies the flags), and fails if one is dynamically linked; 2. runs the binaries' own migrate on fresh databases; 3. boots web and admin with APP_ENV=production and only the config production requires, until /healthz answers 200. It runs only when a build input changed: scripts/affected.sh outputs smoke=true for a full run, a changed Dockerfile, or an affected package that a Dockerfile builds (test files alone do not count). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: give the Check step a minute for the release smoke; document it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(scripts): tidy the dockerfile-builds header Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratch; will be closed.