Skip to content

fix: remove the per-call struct format strings from the response parse path #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaysonsantos merged 2 commits into from
Sep 19, 2026
Merged

fix: remove the per-call struct format strings from the response parse path #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e4c7a
fix: remove the per-call struct format strings from the response pars…
jaysonsantos Sep 8, 2026
fd8178d
style: apply ruff format to the response unpack path
cursoragent Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions bmemcached/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@

logger = logging.getLogger(__name__)

# The value body of a get response starts with a 4 byte flags field. A Struct
# for '!L%ds' would be specific to one value length, so it is not reusable.
# Read the fixed part with this, then slice the rest. A slice compiles nothing.
FLAGS_UNPACKER = struct.Struct("!L")


class Protocol(threading.local):
"""
Expand Down Expand Up @@ -475,7 +480,8 @@ def get(self, key):

raise MemcachedException(f"Code: {status:d} Message: {extra_content}", status)

flags, value = struct.unpack(f"!L{bodylen - 4}s", extra_content)
(flags,) = FLAGS_UNPACKER.unpack_from(extra_content)
value = extra_content[4:]

return self.deserialize(value, flags), cas

Expand Down Expand Up @@ -549,7 +555,9 @@ def get_multi(self, keys):
)

if status == SUCCESS:
flags, key, value = struct.unpack(f"!L{keylen}s{bodylen - keylen - 4}s", extra_content)
(flags,) = FLAGS_UNPACKER.unpack_from(extra_content)
key = extra_content[4 : 4 + keylen]
value = extra_content[4 + keylen :]
d[key] = self.deserialize(value, flags), cas

elif status == DISCONNECTED:
Expand Down
Loading