Skip to content

Fix static pkg-config compile flags - #1485

Merged
SGSSGene merged 1 commit into
jbeder:masterfrom
henriquejsza:fix/1345-static-pkg-config-flags
Aug 24, 2026
Merged

Fix static pkg-config compile flags#1485
SGSSGene merged 1 commit into
jbeder:masterfrom
henriquejsza:fix/1345-static-pkg-config-flags

Conversation

@henriquejsza

Copy link
Copy Markdown
Contributor

Summary

  • emit YAML_CPP_STATIC_DEFINE through Cflags.private for static pkg-config metadata
  • keep shared-library metadata free of the static definition
  • add a CTest regression check for both build modes

Fixes #1345

Testing

  • static and shared CMake/Ninja Release builds
  • ctest (3/3 in each build)
  • install and CMake package consumers in both modes
  • install and pkg-config consumers, including --static --cflags

@SGSSGene SGSSGene left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Hopefully this will reduce some of the windows linkage issues people have!

@SGSSGene
SGSSGene merged commit b11b312 into jbeder:master Aug 24, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yaml-cpp.pc with static linking on Windows

2 participants